Skip to content

[release/3.0.1xx] Update dependencies from aspnet/AspNetCore - #5526

Merged
mmitche merged 5 commits into
release/3.0.1xxfrom
darc-release/3.0.1xx-41883094-9d37-4967-be6a-906a4552b178
Nov 5, 2019
Merged

[release/3.0.1xx] Update dependencies from aspnet/AspNetCore#5526
mmitche merged 5 commits into
release/3.0.1xxfrom
darc-release/3.0.1xx-41883094-9d37-4967-be6a-906a4552b178

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Nov 4, 2019

Copy link
Copy Markdown

This pull request updates the following dependencies

From https://github.com/aspnet/AspNetCore

  • Build: 20191104.7
  • Date Produced: 11/5/2019 3:56 AM
  • Commit: 22dedcb2f0de59022e0383e1f05c9caffc708522
  • Branch: refs/heads/release/3.0
  • Updates:
    • Microsoft.AspNetCore.App.Runtime.win-x64 -> 3.0.1

…0191104.2

- Microsoft.AspNetCore.App.Runtime.win-x64 - 3.0.1
@dotnet-maestro

dotnet-maestro Bot commented Nov 4, 2019

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Arm_NoSuffix_Release), .NET Core core-sdk CI (build Linux Build_LinuxPortable_NoSuffix_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Linux Build_Arm64_Debug), .NET Core core-sdk CI (build Linux Build_Arm_Debug), .NET Core core-sdk CI (build Windows_NT Build_Release_arm), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_DropSuffix_Release_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Darwin Build_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@nguerrera nguerrera left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preventing auto merge so my fixups will get reviewed

@nguerrera

nguerrera commented Nov 4, 2019

Copy link
Copy Markdown

@mmitche @livarcocc Please review d7dbb7e

EDIT: Livar reviewed over my shoulder.

Unpin 3.0.x ASP.NET targeting pack

Revert dotnet-* tools packages to 3.0.0 versions
@nguerrera
nguerrera force-pushed the darc-release/3.0.1xx-41883094-9d37-4967-be6a-906a4552b178 branch from 69e0332 to d7dbb7e Compare November 4, 2019 22:21
@dotnet-maestro

dotnet-maestro Bot commented Nov 4, 2019

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64)
  • Standard Merge Policies There are reviews that have requested changes.

@nguerrera

Copy link
Copy Markdown

@dougbu @JunTaoLuo as well

@dotnet-maestro

This comment has been minimized.

@nguerrera

Copy link
Copy Markdown
EXEC : error : Failed dependencies: [/home/vsts/work/1/s/src/redist/redist.csproj] 

##[error]EXEC(0,0): error : Failed dependencies: 

 dotnet-targeting-pack-3.0 >= 3.0.1 is needed by aspnetcore-targeting-pack-3.0-3.0.1-1.x86_64 

/home/vsts/work/1/s/src/redist/targets/GenerateRPMs.targets(295,5): error MSB3073: The command "sudo rpm -iv /home/vsts/work/1/s/artifacts/obj/redist/Release/downloads/aspnetcore-targeting-pack-3.0.1.rpm" exited with code 1. [/home/vsts/work/1/s/src/redist/redist.csproj] 

##[error]src/redist/targets/GenerateRPMs.targets(295,5): error MSB3073: The command "sudo rpm -iv /home/vsts/work/1/s/artifacts/obj/redist/Release/downloads/aspnetcore-targeting-pack-3.0.1.rpm" exited with code 1.

Looks like https://github.com/aspnet/AspNetCore/blob/41ce223c1cf4ffd482c4ea36e88ed44a94db37b3/src/Installers/Rpm/TargetingPack/Rpm.TargetingPack.rpmproj#L24 is not using the ref package version.

@wtgodbe @mmitche @dougbu

@dotnet-maestro

dotnet-maestro Bot commented Nov 4, 2019

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64)
  • Standard Merge Policies There are reviews that have requested changes.

@nguerrera
nguerrera self-requested a review November 4, 2019 23:24

@nguerrera nguerrera left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RHEL failure is real, not flakiness, so do not merge.

@mmitche
mmitche merged commit 8b9de75 into release/3.0.1xx Nov 5, 2019
@nguerrera

Copy link
Copy Markdown

Why didn't maestro update the version of the VS.Redist package on its own?

@nguerrera
nguerrera deleted the darc-release/3.0.1xx-41883094-9d37-4967-be6a-906a4552b178 branch November 5, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants