Generate warning suppressions in an XML format - #1386
Merged
Merged
Conversation
vitek-karas
requested changes
Jul 27, 2020
marek-safar
reviewed
Jul 29, 2020
vitek-karas
reviewed
Jul 30, 2020
added 2 commits
July 30, 2020 13:43
layomia
reviewed
Jul 31, 2020
added 2 commits
August 3, 2020 18:00
sbomer
approved these changes
Aug 4, 2020
sbomer
left a comment
sbomer
left a comment
Member
There was a problem hiding this comment.
LGTM if you change the sorting behavior. Thanks!
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
* Emit warning suppression files either in cs or xml format Commit migrated from dotnet/linker@e88e769
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1380. This changes the existing
--generate-warning-suppressionsoption to receive a string argument (cs/xml) which tells the suppression writer in which format should the warning suppressions be emitted, either as a C# source file (this is the current behavior) or as an XML file that follows the linker's annotation format./cc @layomia