Add support for property tag on CA annotations - #1397
Merged
Conversation
tlakollo
reviewed
Jul 31, 2020
tlakollo
reviewed
Jul 31, 2020
vitek-karas
reviewed
Jul 31, 2020
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
* Add support for property tag on CA annotations Commit migrated from dotnet/linker@8f32ed5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #1386. This PR adds the ability to set properties when using custom attributes via a linker annotations XML and refactors the
ProcessAttributesmethod which contained much of the logic needed by theLinkAttributesstep./cc @layomia