Skip to content

Update API compat version number to 1.1.0 for stable release packages - #3824

Merged
codemzs merged 1 commit into
dotnet:masterfrom
codemzs:apcompat
Jun 5, 2019
Merged

Update API compat version number to 1.1.0 for stable release packages#3824
codemzs merged 1 commit into
dotnet:masterfrom
codemzs:apcompat

Conversation

@codemzs

@codemzs codemzs commented Jun 4, 2019

Copy link
Copy Markdown
Member

No description provided.

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tools-local/Microsoft.ML.StableApi/Microsoft.ML.StableApi.csproj
<PackageReference Include="Microsoft.ML.LightGbm" Version="1.0.0" />
<PackageReference Include="Microsoft.ML.ImageAnalytics" Version="1.0.0" />
<PackageReference Include="Microsoft.ML.Mkl.Components" Version="1.0.0" />
<PackageReference Include="Microsoft.ML" Version="1.1.0" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious to know how other teams do it, but are we going to keep increasing the reference packages to the latest GA?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine so. @eerhardt thoughts?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be my plan. Once you ship 1.0, you don't want to break any of those APIs. Then you ship new APIs in 1.1. Now as you are building 1.2 you don't want to break those new APIs you just added in 1.1.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's what I thought! It makes total sense. Thanks @eerhardt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codemzs If possible we should add this to the notes on how to release a new version.

@codemzs
codemzs merged commit d4d0f9b into dotnet:master Jun 5, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants