Skip to content

Update API compat version number to 1.1.0 for stable release packages #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codemzs merged 1 commit into from
Jun 5, 2019
Merged

Update API compat version number to 1.1.0 for stable release packages #3824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tools-local/Microsoft.ML.StableApi/Microsoft.ML.StableApi.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.ML" Version="1.0.0" />
<PackageReference Include="Microsoft.ML.DataView" Version="1.0.0" />
<PackageReference Include="Microsoft.ML.CpuMath" Version="1.0.0" />
<PackageReference Include="Microsoft.ML.FastTree" Version="1.0.0" />
<PackageReference Include="Microsoft.ML.LightGbm" Version="1.0.0" />
<PackageReference Include="Microsoft.ML.ImageAnalytics" Version="1.0.0" />
<PackageReference Include="Microsoft.ML.Mkl.Components" Version="1.0.0" />
<PackageReference Include="Microsoft.ML" Version="1.1.0" />

@artidoro artidoro Jun 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious to know how other teams do it, but are we going to keep increasing the reference packages to the latest GA?

@codemzs codemzs Jun 5, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine so. @eerhardt thoughts?

@eerhardt eerhardt Jun 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be my plan. Once you ship 1.0, you don't want to break any of those APIs. Then you ship new APIs in 1.1. Now as you are building 1.2 you don't want to break those new APIs you just added in 1.1.

@artidoro artidoro Jun 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's what I thought! It makes total sense. Thanks @eerhardt

@artidoro artidoro Jun 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codemzs If possible we should add this to the notes on how to release a new version.

<PackageReference Include="Microsoft.ML.DataView" Version="1.1.0" />
<PackageReference Include="Microsoft.ML.CpuMath" Version="1.1.0" />
<PackageReference Include="Microsoft.ML.FastTree" Version="1.1.0" />
<PackageReference Include="Microsoft.ML.LightGbm" Version="1.1.0" />
<PackageReference Include="Microsoft.ML.ImageAnalytics" Version="1.1.0" />
<PackageReference Include="Microsoft.ML.Mkl.Components" Version="1.1.0" />
Comment thread
artidoro marked this conversation as resolved.
</ItemGroup>

<!-- The purpose of this target is to return a path from a referenced
Expand Down