Fixes #4299 related to ML.Samples and ML.Samples.GPU sharing the same Program.cs file - #4300
Conversation
antoniovs1029
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4300 +/- ##
==========================================
- Coverage 74.72% 74.06% -0.67%
==========================================
Files 906 905 -1
Lines 159275 159107 -168
Branches 17142 17128 -14
==========================================
- Hits 119026 117846 -1180
- Misses 35446 36499 +1053
+ Partials 4803 4762 -41
|
| { | ||
| public static void Main(string[] args) => RunAll(); | ||
|
|
||
| internal static void RunAll() |
There was a problem hiding this comment.
As I wrote in the issue, I got runtime errors if I tried to run it with the original content of Program.cs. So I removed that.
Should I put that back into the method?
There was a problem hiding this comment.
What were the errors? Did you run the samples on a machine with a GPU?
If there are errors, then the samples that throw them should be fixed.
In reply to: 331726596 [](ancestors = 331726596)
There was a problem hiding this comment.
My machine doesn't have a dedicated GPU. And now I realize that the exceptions were thrown because I don't have tensorflow installed either.
I will find a machine that has those to run the samples, and if it works then I will return the content of Program.cs.
Thanks for the feedback.
There was a problem hiding this comment.
So I had checked this on another machine, and the samples run with the original content of the Program.cs file, so I've put that back in here.
So, please, approve this PR. Thanks!
There was a problem hiding this comment.
So today I got my machine with a GPU running. And I checked that this works as expected; everything went correctly. Please, approve this PR. Thanks!
There was a problem hiding this comment.
Thanks for verifying that the samples run correctly!
Since they are, is this PR still needed? This file is identical to the one in Microsoft.ML.Samples, isn't it?
In reply to: 337241467 [](ancestors = 337241467)
There was a problem hiding this comment.
Yes, they are identical. The problem was that both projects shared the same file, and when editing the file under ML.Samples to run a specific sample, then some error tooltips appeared when editing it and some build errors occurred when trying to rebuild the solution after making those changes in that file. This happened because ML.Samples.GPU doesn't have access to the same things that ML.Samples.
So these errors didn't appear before, and after talking about it with @codemzs we agreed that I should add another Program.cs file in ML.Samples.GPU with the same content of the one in ML.Samples.
ghost
locked as resolved and limited conversation to collaborators
3 participants
A simple change to fix #4299 . Simply added a new Program.cs file to the ML.Samples.GPU, independent of the one in ML.Samples.