Skip to content

Fixes #4299 related to ML.Samples and ML.Samples.GPU sharing the same Program.cs file #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codemzs merged 7 commits into from
Nov 8, 2019
Merged

Fixes #4299 related to ML.Samples and ML.Samples.GPU sharing the same Program.cs file #4300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
483b22e
Adding a Program.cs to ML.Samples.GPU project, different from the one…
antoniovs1029 Oct 4, 2019
58dcb47
Removing the content in the ML.Samples.GPU main method
antoniovs1029 Oct 4, 2019
3b7e78f
Put again the original content of Program.cs in the ML.Samples.GPU p…
antoniovs1029 Oct 7, 2019
aebbd78
Merge remote-tracking branch 'upstream/master' into samplesgpu
antoniovs1029 Oct 24, 2019
1d2ac0c
Merge from master branch
antoniovs1029 Nov 5, 2019
406f4c9
Remove original Program.cs from Samples.GPU references
antoniovs1029 Nov 5, 2019
13435b3
Merge branch 'samplesgpu' of https://github.com/antoniovs1029/machine…
antoniovs1029 Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/samples/Microsoft.ML.Samples.GPU/Microsoft.ML.Samples.GPU.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
</PropertyGroup>

<ItemGroup>
<Compile Include="..\Microsoft.ML.Samples\Program.cs" Link="Program.cs" />
<Compile Include="..\Microsoft.ML.Samples\Dynamic\Trainers\MulticlassClassification\ImageClassification\*.cs">
<Link>Dynamic\ImageClassification\%(FileName)</Link>
</Compile>
Expand Down
30 changes: 30 additions & 0 deletions docs/samples/Microsoft.ML.Samples.GPU/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
using System;
using System.Reflection;
using Samples.Dynamic;

namespace Microsoft.ML.Samples
{
public static class Program
{
public static void Main(string[] args) => RunAll();

internal static void RunAll()

@codemzs codemzs Oct 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this empty?

@antoniovs1029 antoniovs1029 Oct 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote in the issue, I got runtime errors if I tried to run it with the original content of Program.cs. So I removed that.

Should I put that back into the method?

@yaeldekel yaeldekel Oct 7, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What were the errors? Did you run the samples on a machine with a GPU?
If there are errors, then the samples that throw them should be fixed.

In reply to: 331726596 [](ancestors = 331726596)

@antoniovs1029 antoniovs1029 Oct 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My machine doesn't have a dedicated GPU. And now I realize that the exceptions were thrown because I don't have tensorflow installed either.

I will find a machine that has those to run the samples, and if it works then I will return the content of Program.cs.

Thanks for the feedback.

@antoniovs1029 antoniovs1029 Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I had checked this on another machine, and the samples run with the original content of the Program.cs file, so I've put that back in here.

So, please, approve this PR. Thanks!

@antoniovs1029 antoniovs1029 Oct 21, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So today I got my machine with a GPU running. And I checked that this works as expected; everything went correctly. Please, approve this PR. Thanks!

@yaeldekel yaeldekel Oct 22, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for verifying that the samples run correctly!
Since they are, is this PR still needed? This file is identical to the one in Microsoft.ML.Samples, isn't it?

In reply to: 337241467 [](ancestors = 337241467)

@antoniovs1029 antoniovs1029 Oct 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are identical. The problem was that both projects shared the same file, and when editing the file under ML.Samples to run a specific sample, then some error tooltips appeared when editing it and some build errors occurred when trying to rebuild the solution after making those changes in that file. This happened because ML.Samples.GPU doesn't have access to the same things that ML.Samples.

So these errors didn't appear before, and after talking about it with @codemzs we agreed that I should add another Program.cs file in ML.Samples.GPU with the same content of the one in ML.Samples.

{
int samples = 0;
var types = Assembly.GetExecutingAssembly().GetTypes();
foreach (var type in types)
{
var sample = type.GetMethod("Example", BindingFlags.Public | BindingFlags.Static | BindingFlags.FlattenHierarchy);

if (sample != null)
{
Console.WriteLine(type.Name);
sample.Invoke(null, null);
samples++;
}
}

Console.WriteLine("Number of samples that ran without any exception: " + samples);
}
}
}