Fix binding project LinkWithAttributes generation to prevent unnecess… - #1029
Merged
Conversation
Contributor
Author
|
Repeat of #1017 but this time not early merged. |
Contributor
Author
|
Similar in spirit to #1014 but should fix both XI and XM since logic is shared in this case. This patch assumes PR 1014 lands first, It might not build w\o the other test changes (I just cherry picked for review). |
spouliot
suggested changes
Oct 25, 2016
| } | ||
| if (!skipLinkWithGeneration) { | ||
| Directory.CreateDirectory (Path.GetDirectoryName (linkWith)); | ||
| File.WriteAllText (linkWith, text.ToString ()); |
Contributor
There was a problem hiding this comment.
you might be calling text.ToString() twice (not sure if it's cached, assuming it's a StringBuilder)
spouliot
approved these changes
Oct 25, 2016
rolfbjarne
approved these changes
Oct 26, 2016
Contributor
|
Build failure |
1 similar comment
Contributor
|
Build failure |
Member
|
@chamons it doesn't merge cleanly anymore, can you fix? |
Contributor
Author
|
@rolfbjarne Fixed. Will wait for build. |
Contributor
|
Build failure |
Member
Member
|
This is dependent on PR #1014, which is already merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ary rebuilds