Fix XM dependency tracking of mmp bundle to prevent rebuilds - #1014
Merged
Conversation
- https://bugzilla.xamarin.com/show_bug.cgi?id=45764 - _CompileToNative's output in msbuild was incorrectly set to: $(_AppBundlePath)Contents\MacOS\$(TargetFileName) when the generated file lives at $(_AppBundlePath)Contents\MonoBundle\$(TargetFileName). - This means we'd always try to rebuild, which can be rather time consuming. - The XI target file is just different enough to require a seperate fix.
Contributor
Author
|
The fix is a one-liner but adding the ability to run a build w\ diagnostic and updating the tests calling it took 3 more files... |
Contributor
Author
|
@spouliot I believe this (and the companion XI fix) should make C9. Thoughts? |
Contributor
|
@chamons agreed, if everyone and the bots are happy we'll merge it before other riskier fixes (and before |
Member
|
Looks good to me. |
rolfbjarne
approved these changes
Oct 21, 2016
Member
|
build |
Contributor
|
Build success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file lives at