Skip to content

[mtouch] Fix embedding Mono (and Xamarin) as frameworks. Fixes #10382 - #10400

Merged
spouliot merged 1 commit into
dotnet:mainfrom
spouliot:gh10382
Jan 13, 2021
Merged

[mtouch] Fix embedding Mono (and Xamarin) as frameworks. Fixes #10382#10400
spouliot merged 1 commit into
dotnet:mainfrom
spouliot:gh10382

Conversation

@spouliot

@spouliot spouliot commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

This broke with 1582bf4 and cause the
frameworks to be nested under another Frameworks directory.

See #10382

Sebastien Pouliot
[mtouch] Fix embedding Mono (and Xamarin) as frameworks. Fixes dotnet…
e161459 
…#10382

This broke with 1582bf4 and cause the
frameworks to be nested under another `Frameworks` directory.

See dotnet#10382
@spouliot
spouliot requested a review from rolfbjarne as a code owner January 12, 2021 22:56
@spouliot spouliot added the not-notes-worthy Ignore for release notes label Jan 13, 2021
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

Test results

1 tests failed, 40 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

Pipeline on Agent XAMBOT-1095'

@rolfbjarne rolfbjarne mentioned this pull request Jan 13, 2021
Merged
@spouliot

spouliot commented Jan 13, 2021

Copy link
Copy Markdown
Contributor Author

MTouch tests/NUnit: Failed (Execution failed with exit code 5)
Remaining failures are network related -> https://github.com/xamarin/maccore/issues/2154

@spouliot
spouliot merged commit d9b0097 into dotnet:main Jan 13, 2021
@spouliot
spouliot deleted the gh10382 branch January 13, 2021 13:23
@monojenkins

monojenkins commented Jan 13, 2021

Copy link
Copy Markdown
Contributor

Build failure
❌ Build failed or was aborted

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)

@rolfbjarne rolfbjarne mentioned this pull request Jan 13, 2021
Merged
@rolfbjarne

rolfbjarne commented Jan 20, 2021

Copy link
Copy Markdown
Member

/sudo backport d16-9

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jan 20, 2021

Copy link
Copy Markdown
Collaborator

Backport Job Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jan 20, 2021

Copy link
Copy Markdown
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4386948 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spouliot @vs-mobiletools-engineering-service2 @monojenkins @rolfbjarne @dalexsoto