[d16-9] [mtouch] Fix embedding Mono (and Xamarin) as frameworks. Fixes #10382 - #10471
Merged
Conversation
vs-mobiletools-engineering-service2
requested review from
rolfbjarne and
spouliot
as code owners
January 20, 2021 07:04
rolfbjarne
approved these changes
Jan 20, 2021
Collaborator
Author
❌ Tests failed on Build ❌Tests failed on Build. Test results6 tests failed, 35 tests passed.Failed tests
Pipeline on Agent XAMBOT-1103' |
Contributor
|
/sudo rebase d16-9 |
Collaborator
Author
|
Rebase Job Created! |
Collaborator
Author
|
Hooray! Rebase succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4387358 for more details. |
azure-pipelines
Bot
force-pushed
the
backport-pr-10400-to-d16-9
branch
from
January 20, 2021 12:43
5f4b875 to
4e82505
Compare
Contributor
|
Tests are failing because the branch from the bot is missing a commit: #10396 |
dalexsoto
approved these changes
Jan 20, 2021
spouliot
approved these changes
Jan 20, 2021
stephen-hawley
approved these changes
Jan 20, 2021
Collaborator
Author
❌ Tests failed on Build ❌Tests failed on Build. Test results7 tests failed, 34 tests passed.Failed tests
Pipeline on Agent XAMBOT-1103' |
tj-devel709
approved these changes
Jan 21, 2021
dalexsoto
force-pushed
the
backport-pr-10400-to-d16-9
branch
from
January 22, 2021 22:35
4e82505 to
777ba2f
Compare
Collaborator
Author
❌ Tests failed on Build ❌Tests failed on Build. Test results8 tests failed, 167 tests passed.Failed tests
Pipeline on Agent XAMBOT-1106' |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke with 1582bf4 and cause the
frameworks to be nested under another
Frameworksdirectory.See #10382
Backport of #10400