[security] Remove port number from TLS Server Name Identification (SNI). Fixes #45994 - #1327
Merged
Conversation
…I). Fixes #45994 The port number should not be included along the host name. Otherwise the server will refuse the connection (and we'll throw). This is a problem when servers are not using the default (443) SSL/TLS port. ref: https://bugzilla.xamarin.com/show_bug.cgi?id=45994 Another PR [1] was made to fix MonoTLS in mono/master [2]. While disable in C19 (master) we'll need this fixed when backporting to C9 [1] mono/mono#4120 [2] https://bugzilla.xamarin.com/show_bug.cgi?id=46549
Contributor
|
Build failure |
Contributor
Author
|
failures are unrelated, timeouts on xam-mac-mini-1 in:
|
spouliot
added a commit
that referenced
this pull request
Dec 9, 2016
…I). Fixes #45994 (#1327) The port number should not be included along the host name. Otherwise the server will refuse the connection (and we'll throw). This is a problem when servers are not using the default (443) SSL/TLS port. ref: https://bugzilla.xamarin.com/show_bug.cgi?id=45994 Another PR [1] was made to fix MonoTLS in mono/master [2]. While disable in C19 (master) we'll need this fixed when backporting to C9 [1] mono/mono#4120 [2] https://bugzilla.xamarin.com/show_bug.cgi?id=46549
spouliot
added a commit
that referenced
this pull request
Dec 14, 2016
…I). Fixes #45994 (#1327) The port number should not be included along the host name. Otherwise the server will refuse the connection (and we'll throw). This is a problem when servers are not using the default (443) SSL/TLS port. ref: https://bugzilla.xamarin.com/show_bug.cgi?id=45994 Another PR [1] was made to fix MonoTLS in mono/master [2]. While disable in C19 (master) we'll need this fixed when backporting to C9 [1] mono/mono#4120 [2] https://bugzilla.xamarin.com/show_bug.cgi?id=46549
chamons
pushed a commit
that referenced
this pull request
Dec 14, 2016
…I). Fixes #45994 (#1327) The port number should not be included along the host name. Otherwise the server will refuse the connection (and we'll throw). This is a problem when servers are not using the default (443) SSL/TLS port. ref: https://bugzilla.xamarin.com/show_bug.cgi?id=45994 Another PR [1] was made to fix MonoTLS in mono/master [2]. While disable in C19 (master) we'll need this fixed when backporting to C9 [1] mono/mono#4120 [2] https://bugzilla.xamarin.com/show_bug.cgi?id=46549
rolfbjarne
added a commit
that referenced
this pull request
Jan 10, 2019
Commit list for xamarin/maccore: * xamarin/maccore@83bd122dd3 [install-qa-provisioning-profiles] Make sure we find pencil_pusher. (#1328) * xamarin/maccore@2df4e9934d Merge pull request #1327 from xamarin/swift-o-matic-override-init * xamarin/maccore@a95796666b Bump to ignore stubbed constructors. Diff: xamarin/maccore@6324465...83bd122
rolfbjarne
added a commit
that referenced
this pull request
Jan 11, 2019
* Bump maccore to get fix for maccore#1325. Commit list for xamarin/maccore: * xamarin/maccore@6324465797 [install-qa-provisioning-profiles] Make sure we find ruby and its related tools. (#1324) [...] Many irrelevant SoM commits [...] Diff: xamarin/maccore@e3d92b5...6324465 * Bump maccore to get an additional fix. Commit list for xamarin/maccore: * xamarin/maccore@83bd122dd3 [install-qa-provisioning-profiles] Make sure we find pencil_pusher. (#1328) * xamarin/maccore@2df4e9934d Merge pull request #1327 from xamarin/swift-o-matic-override-init * xamarin/maccore@a95796666b Bump to ignore stubbed constructors. Diff: xamarin/maccore@6324465...83bd122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The port number should not be included along the host name. Otherwise
the server will refuse the connection (and we'll throw). This is a
problem when servers are not using the default (443) SSL/TLS port.
ref: https://bugzilla.xamarin.com/show_bug.cgi?id=45994
Another PR [1] was made to fix MonoTLS in mono/master [2]. While
disable in C19 (master) we'll need this fixed when backporting to C9
[1] mono/mono#4120
[2] https://bugzilla.xamarin.com/show_bug.cgi?id=46549