Skip to content

Bump maccore to get fix for maccore#1325. - #5366

Merged
rolfbjarne merged 2 commits into
masterfrom
bump-maccore-issue-1525
Jan 11, 2019
Merged

Bump maccore to get fix for maccore#1325.#5366
rolfbjarne merged 2 commits into
masterfrom
bump-maccore-issue-1525

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Jan 9, 2019

Copy link
Copy Markdown
Member

Commit list for xamarin/maccore:

Diff: https://github.com/xamarin/maccore/compare/e3d92b50d6beb38b154a3dfe9242720c67f8d7c3...6324465797efb3ae9185e1bb1d4645499c6e1e7c

@rolfbjarne
Bump maccore to get fix for maccore#1325.
9a4aaec 
Commit list for xamarin/maccore:

* xamarin/maccore@6324465797 [install-qa-provisioning-profiles] Make sure we find ruby and its related tools. (#1324)
[...] Many irrelevant SoM commits [...]

Diff: xamarin/maccore@e3d92b5...6324465
@rolfbjarne rolfbjarne added run-internal-tests If tests should be executed on the internal Jenkins instance. skip-public-jenkins Completely skip execution in the public Jenkins instance labels Jan 9, 2019
@monojenkins

monojenkins commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

Build success
ℹ️ Skipped execution

@xamarin-release-manager

xamarin-release-manager commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Install Provisioning Profiles' 🔥 : hudson.AbortException: script returned exit code 127

✅ Build succeeded
✅ Packages: xamarin.ios-12.7.0.36.pkg xamarin.mac-5.7.0.36.pkg

@rolfbjarne

rolfbjarne commented Jan 10, 2019

Copy link
Copy Markdown
Member Author

Looks like the maccore fix is incomplete; we'll need https://github.com/xamarin/maccore/pull/1328 as well.

@rolfbjarne
Bump maccore to get an additional fix.
fedcbfa 
Commit list for xamarin/maccore:

* xamarin/maccore@83bd122dd3 [install-qa-provisioning-profiles] Make sure we find pencil_pusher. (#1328)
* xamarin/maccore@2df4e9934d Merge pull request #1327 from xamarin/swift-o-matic-override-init
* xamarin/maccore@a95796666b Bump to ignore stubbed constructors.

Diff: xamarin/maccore@6324465...83bd122
@monojenkins

monojenkins commented Jan 10, 2019

Copy link
Copy Markdown
Contributor

Build success
ℹ️ Skipped execution

@xamarin-release-manager

xamarin-release-manager commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.7.0.37.pkg xamarin.mac-5.7.0.37.pkg
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
✅ Test run succeeded

@rolfbjarne

rolfbjarne commented Jan 11, 2019

Copy link
Copy Markdown
Member Author

API/generator diff failure is unrelated (https://github.com/xamarin/maccore/issues/1323)

@rolfbjarne
rolfbjarne merged commit 0496a39 into master Jan 11, 2019
@rolfbjarne
rolfbjarne deleted the bump-maccore-issue-1525 branch January 11, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
+2 more reviewers
@spouliot spouliot spouliot approved these changes
@chamons chamons chamons approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run-internal-tests If tests should be executed on the internal Jenkins instance. skip-public-jenkins Completely skip execution in the public Jenkins instance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rolfbjarne @monojenkins @xamarin-release-manager @dalexsoto @spouliot @chamons