[objcruntime] Simplified earlier split of internal Lookup method - #14138
Merged
Conversation
The split [1] was done to ease nullability annotations since there's no syntax to cover this specific case with custom attributes. However we don't need three methods for the split. Two are enough :) [1] dotnet#13281
dalexsoto
approved these changes
Feb 15, 2022
rolfbjarne
approved these changes
Feb 15, 2022
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diff✅ Generator Diff (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 107 tests passed.Failed tests
Pipeline on Agent XAMBOT-1105.BigSur' |
Member
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2443). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The split [1] was done to ease nullability annotations since there's no
syntax to cover this specific case with custom attributes.
However we don't need three methods for the split. Two are enough :)
[1] #13281