[Class] Enable nullability + fix a few code updates. - #13281
Merged
Conversation
rolfbjarne
commented
Nov 4, 2021
rolfbjarne
commented
Member
- Enable nullability and fix code accordingly.
- Use 'is' and 'is not' instead of '==' and '!=' for object identity.
- Use 'nameof (parameter)' instead of string constants.
- Make the 'handle' field private.
- Remove the (IntPtr) constructor for .NET
- Make the (IntPtr, bool) constructor internal for .NET
- Remove unused 'Construct' method.
* Enable nullability and fix code accordingly. * Use 'is' and 'is not' instead of '==' and '!=' for object identity. * Use 'nameof (parameter)' instead of string constants. * Make the 'handle' field private. * Remove the (IntPtr) constructor for .NET * Make the (IntPtr, bool) constructor internal for .NET * Remove unused 'Construct' method.
mandel-macaque
approved these changes
Nov 4, 2021
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results6 tests failed, 93 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
Therzok
reviewed
Nov 4, 2021
It'll be the only way to create a Class instance given an IntPtr.
Collaborator
❌ [CI Build] Tests didn't execute on Build. ❌Tests didn't execute on Build. No test summary was found (something probably failed before the tests could execute) |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tj-devel709
approved these changes
Nov 5, 2021
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results7 tests failed, 92 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
dalexsoto
approved these changes
Nov 6, 2021
Member
Author
|
Test failures are unrelated:
Build is currently broken in main, waiting to merge until that's fixed (#13304). |
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Feb 15, 2022
The split [1] was done to ease nullability annotations since there's no syntax to cover this specific case with custom attributes. However we don't need three methods for the split. Two are enough :) [1] dotnet#13281
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Feb 15, 2022
That was mentioned > Remove the (IntPtr) constructor for .NET inside dotnet#13281 but not actually done inside that PR
rolfbjarne
pushed a commit
that referenced
this pull request
Feb 15, 2022
rolfbjarne
pushed a commit
that referenced
this pull request
Feb 15, 2022
That was mentioned > Remove the (IntPtr) constructor for .NET inside #13281 but not actually done inside that PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.