Skip to content

[net][objcruntime] Remove Class (IntPtr) for .net profile - #14140

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
spouliot:class-remove-ctor-intptr-from-net
Feb 15, 2022
Merged

[net][objcruntime] Remove Class (IntPtr) for .net profile#14140
rolfbjarne merged 1 commit into
dotnet:mainfrom
spouliot:class-remove-ctor-intptr-from-net

Conversation

@spouliot

Copy link
Copy Markdown
Contributor

That was mentioned

Remove the (IntPtr) constructor for .NET

inside #13281
but not actually done inside that PR

That was mentioned

> Remove the (IntPtr) constructor for .NET

inside dotnet#13281
but not actually done inside that PR
@rolfbjarne

Copy link
Copy Markdown
Member

I had removed it, but then ended up putting it back in again, although right now I don't remember why. Maybe the tests will help :)

@rolfbjarne

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rolfbjarne rolfbjarne added community Community contribution ❤ run-dotnet-tests Run all the .NET tests labels Feb 15, 2022
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 148 tests passed 🎉

Pipeline on Agent XAMBOT-1102.BigSur'
Merge 849b36a into f36606e

@rolfbjarne
rolfbjarne merged commit 5bb9434 into dotnet:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Community contribution ❤ run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants