Skip to content

[tests] Ignore SWCollaborationView in DelegateAndSourceTest. - #16777

Merged
rolfbjarne merged 3 commits into
dotnet:mainfrom
rolfbjarne:monotouch-test-ventura
Nov 18, 2022
Merged

[tests] Ignore SWCollaborationView in DelegateAndSourceTest.#16777
rolfbjarne merged 3 commits into
dotnet:mainfrom
rolfbjarne:monotouch-test-ventura

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Nov 16, 2022

Copy link
Copy Markdown
Member

[SWCollaborationView setDelegate:] crashes when passed null.

rolfbjarne and others added 2 commits November 16, 2022 09:38
@rolfbjarne
[tests] Ignore SWCollaborationView in DelegateAndSourceTest.
d83dbf1 
[SWCollaborationView setDelegate:] crashes when passed null.
GitHub Actions Autoformatter
Auto-format source code
a014483
@github-actions

This comment was marked as outdated.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 87ae9f848f459f21cab427d5f977ca95b5d8bf58 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent XAMBOT-1168.Monterey'
Hash: 87ae9f848f459f21cab427d5f977ca95b5d8bf58 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 87ae9f848f459f21cab427d5f977ca95b5d8bf58 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ monotouch tests

1 tests failed, 22 tests passed.
Details
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 87ae9f848f459f21cab427d5f977ca95b5d8bf58 [PR build]

@rolfbjarne

rolfbjarne commented Nov 17, 2022

Copy link
Copy Markdown
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450).

@rolfbjarne
rolfbjarne merged commit 1c29665 into dotnet:main Nov 18, 2022
@rolfbjarne
rolfbjarne deleted the monotouch-test-ventura branch November 18, 2022 07:02
rolfbjarne added a commit to rolfbjarne/macios that referenced this pull request Mar 17, 2023
@rolfbjarne GitHub Actions Autoformatter
[tests] Ignore SWCollaborationView in DelegateAndSourceTest. (dotnet#…
8b3fca0 
…16777)

[SWCollaborationView setDelegate:] crashes when passed null.

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
This was referenced Mar 17, 2023
Merged
Merged
Merged
rolfbjarne added a commit to rolfbjarne/macios that referenced this pull request Mar 17, 2023
@rolfbjarne GitHub Actions Autoformatter
[tests] Ignore SWCollaborationView in DelegateAndSourceTest. (dotnet#…
3f96fee 
…16777)

[SWCollaborationView setDelegate:] crashes when passed null.

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
rolfbjarne added a commit to rolfbjarne/macios that referenced this pull request Mar 17, 2023
@rolfbjarne GitHub Actions Autoformatter
[tests] Ignore SWCollaborationView in DelegateAndSourceTest. (dotnet#…
ced0c97 
…16777)

[SWCollaborationView setDelegate:] crashes when passed null.

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
rolfbjarne added a commit that referenced this pull request Mar 21, 2023
@rolfbjarne @dustin-wojciechowski GitHub Actions Autoformatter
[release/7.0.1xx-xcode14.2] Add ventura to mac tests configurations. (#…
1326c4f 
…17816)

Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #17349, #16743, and #16777.

---------

Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
rolfbjarne added a commit that referenced this pull request Mar 21, 2023
@rolfbjarne @dustin-wojciechowski GitHub Actions Autoformatter
[release/7.0.2xx] Add ventura to mac tests configurations. (#17815)
1869049 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #17349, #16743, and #16777.

---------

Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
rolfbjarne added a commit that referenced this pull request Mar 21, 2023
@rolfbjarne @dustin-wojciechowski GitHub Actions Autoformatter
[release/6.0.4xx-xcode14.2] Add ventura to mac tests configurations. (#…
e37bd23 
…17817)

Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #17349, #16743, and #16777.

---------

Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
rolfbjarne added a commit to rolfbjarne/macios that referenced this pull request Mar 30, 2023
@rolfbjarne GitHub Actions Autoformatter
[tests] Ignore SWCollaborationView in DelegateAndSourceTest. (dotnet#…
c921af4 
…16777)

[SWCollaborationView setDelegate:] crashes when passed null.

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mandel-macaque mandel-macaque mandel-macaque approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @mandel-macaque