Skip to content

Add ventura to mac tests configurations - #17349

Merged
dalexsoto merged 25 commits into
mainfrom
add-ventura-to-macTestsConfigurations
Feb 13, 2023
Merged

Add ventura to mac tests configurations#17349
dalexsoto merged 25 commits into
mainfrom
add-ventura-to-macTestsConfigurations

Conversation

@dustin-wojciechowski

@dustin-wojciechowski dustin-wojciechowski commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

Added Ventura machines to macTestConfigurations within both the build-ci-pipeline and the build-pr-pipelines.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@dalexsoto

dalexsoto commented Jan 24, 2023

Copy link
Copy Markdown
Member

Here is the bulk of the test failures reported by the Ventura bots:

https://gist.github.com/dalexsoto/70412a0bb98d5794783827700018f49c

rolfbjarne
rolfbjarne requested changes Jan 24, 2023
View reviewed changes

@rolfbjarne rolfbjarne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally Ventura test results! But we'll need to fix the test failures before we can merge the PR.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne
rolfbjarne force-pushed the add-ventura-to-macTestsConfigurations branch from f9b0876 to 91c904c Compare January 24, 2023 13:58
@rolfbjarne
rolfbjarne removed request for emaf and mauroa January 24, 2023 13:58
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
mandel-macaque
mandel-macaque suggested changes Jan 24, 2023
View reviewed changes

@mandel-macaque mandel-macaque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml code is perfect, but as already mentioned, we need to fix the tests and then land this.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@dustin-wojciechowski

dustin-wojciechowski commented Jan 31, 2023

Copy link
Copy Markdown
Contributor Author

Note: Introspection tests aren't working in the test runner for me so need to fix that. So apologies if something is blatantly wrong... I'm working towards getting all the tests to run now. But please let me know if my edits aren't correct for the various tests.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@dalexsoto

dalexsoto commented Feb 9, 2023

Copy link
Copy Markdown
Member

@rolfbjarne / @mandel-macaque I think this is ready for review

rolfbjarne
rolfbjarne requested changes Feb 9, 2023
View reviewed changes
Comment thread tests/introspection/ApiTypoTest.cs Outdated
Comment thread tests/monotouch-test/MetalPerformanceShaders/MnistTest.cs Outdated
Comment thread tests/common/TestRuntime.cs Outdated
dalexsoto
dalexsoto reviewed Feb 9, 2023
View reviewed changes
Comment thread tests/monotouch-test/MetalPerformanceShaders/MnistTest.cs Outdated
@dalexsoto @rolfbjarne
Apply suggestions from code review
ce44702 
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@dalexsoto

dalexsoto commented Feb 9, 2023

Copy link
Copy Markdown
Member

Thanks @rolfbjarne, suggestions are applied.

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ce447020a4e4ab68d380b82c1e30ac2c9f13b70e [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: ce447020a4e4ab68d380b82c1e30ac2c9f13b70e [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-010.Monterey'
Hash: ce447020a4e4ab68d380b82c1e30ac2c9f13b70e [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: ce447020a4e4ab68d380b82c1e30ac2c9f13b70e [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ce447020a4e4ab68d380b82c1e30ac2c9f13b70e [PR build]

@dalexsoto
dalexsoto merged commit 3eeb769 into main Feb 13, 2023
@dalexsoto
dalexsoto deleted the add-ventura-to-macTestsConfigurations branch February 13, 2023 16:08
@rolfbjarne rolfbjarne mentioned this pull request Feb 13, 2023
Merged
mandel-macaque pushed a commit that referenced this pull request Mar 3, 2023
@dustin-wojciechowski @dalexsoto
@rolfbjarne @mandel-macaque
Add ventura to mac tests configurations (#17349)
2b8e55d 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

---------

Co-authored-by: Alex Soto <alex@alexsoto.me>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@rolfbjarne rolfbjarne mentioned this pull request Mar 16, 2023
Merged
rolfbjarne pushed a commit to rolfbjarne/macios that referenced this pull request Mar 16, 2023
@dustin-wojciechowski @rolfbjarne
[release/7.0.2xx] Add ventura to mac tests configurations.
765c3e9 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #dotnet#17349.
@rolfbjarne rolfbjarne mentioned this pull request Mar 16, 2023
Merged
rolfbjarne pushed a commit to rolfbjarne/macios that referenced this pull request Mar 16, 2023
@dustin-wojciechowski @rolfbjarne
[release/7.0.1xx-xcode14.2] Add ventura to mac tests configurations.
49ae787 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #dotnet#17349.
@rolfbjarne rolfbjarne mentioned this pull request Mar 16, 2023
Merged
rolfbjarne pushed a commit to rolfbjarne/macios that referenced this pull request Mar 16, 2023
@dustin-wojciechowski @rolfbjarne
[release/6.0.4xx-xcode14.2] Add ventura to mac tests configurations.
906a1a9 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #dotnet#17349.
rolfbjarne added a commit that referenced this pull request Mar 21, 2023
@rolfbjarne @dustin-wojciechowski GitHub Actions Autoformatter
[release/7.0.1xx-xcode14.2] Add ventura to mac tests configurations. (#…
1326c4f 
…17816)

Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #17349, #16743, and #16777.

---------

Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
rolfbjarne added a commit that referenced this pull request Mar 21, 2023
@rolfbjarne @dustin-wojciechowski GitHub Actions Autoformatter
[release/7.0.2xx] Add ventura to mac tests configurations. (#17815)
1869049 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #17349, #16743, and #16777.

---------

Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
rolfbjarne added a commit that referenced this pull request Mar 21, 2023
@rolfbjarne @dustin-wojciechowski GitHub Actions Autoformatter
[release/6.0.4xx-xcode14.2] Add ventura to mac tests configurations. (#…
e37bd23 
…17817)

Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #17349, #16743, and #16777.

---------

Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
@rolfbjarne rolfbjarne mentioned this pull request Mar 30, 2023
Merged
rolfbjarne added a commit to rolfbjarne/macios that referenced this pull request Mar 30, 2023
@dustin-wojciechowski @dalexsoto @rolfbjarne
[xcode14.2] Add ventura to mac tests configurations
c939e07 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of dotnet#17349.

---------

Co-authored-by: Alex Soto <alex@alexsoto.me>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne added a commit that referenced this pull request Apr 11, 2023
@rolfbjarne @dustin-wojciechowski
@dalexsoto GitHub Actions Autoformatter
[xcode14.2] Add ventura to mac tests configurations (#17945)
d45953d 
Added Ventura machines to macTestConfigurations within both the
build-ci-pipeline and the build-pr-pipelines.

This is a backport of #17349.

---------

Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: Alex Soto <alex@alexsoto.me>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@rolfbjarne rolfbjarne rolfbjarne approved these changes
+1 more reviewer
@mandel-macaque mandel-macaque mandel-macaque approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dalexsoto dalexsoto

Labels

actions-disable-autoformat Disable autoformatting C# code according to our style guidelines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dustin-wojciechowski @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @mandel-macaque