[src] Remove availability attributes on error enums. by rolfbjarne · Pull Request #16810 · dotnet/macios

rolfbjarne · 2022-11-18T07:20:22Z

Fixes these test failures:

1) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/32bits/iOS/Xamarin.iOS.dll")
   CoreLocation.CLError.HistoricalLocationError
   Expected: <empty>
   But was:  < "CoreLocation.CLError.HistoricalLocationError" >
   at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29

2) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/iOS/Xamarin.iOS.dll")
   CoreLocation.CLError.HistoricalLocationError
   Expected: <empty>
   But was:  < "CoreLocation.CLError.HistoricalLocationError" >
   at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29

3) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/32bits/watchOS/Xamarin.WatchOS.dll")
   WatchKit.WKExtendedRuntimeSessionErrorCode.MustBeActiveToPrompt, WatchKit.WKExtendedRuntimeSessionErrorCode.UnsupportedSessionType, CoreLocation.CLError.HistoricalLocationError
   Expected: <empty>
   But was:  < "WatchKit.WKExtendedRuntimeSessionErrorCode.MustBeActiveToPrompt", "WatchKit.WKExtendedRuntimeSessionErrorCode.UnsupportedSessionType", "CoreLocation.CLError.HistoricalLocationError" >
   at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29

4) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/tvOS/Xamarin.TVOS.dll")
   CoreLocation.CLError.HistoricalLocationError
   Expected: <empty>
   But was:  < "CoreLocation.CLError.HistoricalLocationError" >
   at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29

5) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/Xamarin.Mac.dll")
   CoreLocation.CLError.HistoricalLocationError
   Expected: <empty>
   But was:  < "CoreLocation.CLError.HistoricalLocationError" >
   at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29

6) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/4.5/Xamarin.Mac.dll")
   CoreLocation.CLError.HistoricalLocationError
   Expected: <empty>
   But was:  < "CoreLocation.CLError.HistoricalLocationError" >
   at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29

Fixes these test failures: 1) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/32bits/iOS/Xamarin.iOS.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 2) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/iOS/Xamarin.iOS.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 3) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/32bits/watchOS/Xamarin.WatchOS.dll") WatchKit.WKExtendedRuntimeSessionErrorCode.MustBeActiveToPrompt, WatchKit.WKExtendedRuntimeSessionErrorCode.UnsupportedSessionType, CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "WatchKit.WKExtendedRuntimeSessionErrorCode.MustBeActiveToPrompt", "WatchKit.WKExtendedRuntimeSessionErrorCode.UnsupportedSessionType", "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 4) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/tvOS/Xamarin.TVOS.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 5) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/Xamarin.Mac.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 6) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/4.5/Xamarin.Mac.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29

vs-mobiletools-engineering-service2 · 2022-11-18T08:56:19Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ef2ad2435643810646c59d9a509f5090c797c242 [PR build]

vs-mobiletools-engineering-service2 · 2022-11-18T09:08:26Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: ef2ad2435643810646c59d9a509f5090c797c242 [PR build]

vs-mobiletools-engineering-service2 · 2022-11-18T09:08:41Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1035.Monterey'
Hash: ef2ad2435643810646c59d9a509f5090c797c242 [PR build]

vs-mobiletools-engineering-service2 · 2022-11-18T14:18:22Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 221 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.

Details

[xUnit] Mono SystemCoreXunit Part 1/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ msbuild tests

1 tests failed, 1 tests passed.

Details

MSBuild tests/Tasks: Failed (Execution failed with exit code 19)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ef2ad2435643810646c59d9a509f5090c797c242 [PR build]

rolfbjarne · 2022-11-18T14:25:37Z

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2450, #16810).

Fixes these test failures: 1) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/32bits/iOS/Xamarin.iOS.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 2) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/iOS/Xamarin.iOS.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 3) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/32bits/watchOS/Xamarin.WatchOS.dll") WatchKit.WKExtendedRuntimeSessionErrorCode.MustBeActiveToPrompt, WatchKit.WKExtendedRuntimeSessionErrorCode.UnsupportedSessionType, CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "WatchKit.WKExtendedRuntimeSessionErrorCode.MustBeActiveToPrompt", "WatchKit.WKExtendedRuntimeSessionErrorCode.UnsupportedSessionType", "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 4) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/tvOS/Xamarin.TVOS.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 5) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/Xamarin.Mac/Xamarin.Mac.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29 6) Failed : Cecil.Tests.EnumTest.NoAvailabilityOnError("/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/mono/4.5/Xamarin.Mac.dll") CoreLocation.CLError.HistoricalLocationError Expected: <empty> But was: < "CoreLocation.CLError.HistoricalLocationError" > at Cecil.Tests.EnumTest.NoAvailabilityOnError (System.String assemblyPath) [0x00067] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/cecil-tests/EnumTest.cs:29

rolfbjarne requested a review from dalexsoto as a code owner November 18, 2022 07:20

This was referenced Nov 18, 2022

[autoformat] Add the PassKit, PdfKit, Photos, PhotosUI, PrintCore, QTKit, QuickLookUI, ReplayKit, SafariServices, ScreenCaptureKit, ScriptingBridge and SearchKit frameworks. #16775

Merged

[tests] Don't run watchOS tests for .NET. #16809

Merged

rolfbjarne mentioned this pull request Nov 18, 2022

[autoformat] Add .NET tests. #16811

Merged

tj-devel709 approved these changes Nov 18, 2022

View reviewed changes

This was referenced Nov 21, 2022

[Cecil] Tests will fail if we do use AvailabilityAttr on an Error enum. #16837

Closed

[main] Update dependencies from dotnet/installer #16825

Merged

rolfbjarne merged commit 3137ef5 into dotnet:main Nov 21, 2022

rolfbjarne deleted the tests-fix-availability-on-error branch November 21, 2022 08:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[src] Remove availability attributes on error enums. - #16810

[src] Remove availability attributes on error enums.#16810
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:tests-fix-availability-on-error

rolfbjarne commented Nov 18, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 18, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 18, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 18, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 18, 2022

Uh oh!

rolfbjarne commented Nov 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rolfbjarne commented Nov 18, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 18, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 18, 2022

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 18, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 18, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ bcl tests

❌ msbuild tests

Successes

Uh oh!

rolfbjarne commented Nov 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants