Merge main into net8.0. - #16793
Merged
rolfbjarne merged 58 commits intoNov 21, 2022
Merged
Conversation
…otnet#16730) Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…otnet#16721) There was a typo in the target name for creating the html report for .NET ('report-dotnet' vs 'dotnet-report'). Also print out the full path the html report when it's created, makes it much easier to open the file from the command line because I can c&p the entire path.
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…t#16736) Allow to add a dependency before our build. This is used in the unified pipeline to try to download the binaries if it can rather than building from scratch. Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…lthKit and HomeKit frameworks. (dotnet#16716)
This pull request updates the following dependencies ## From https://github.com/dotnet/installer - **Subscription**: 50c9492e-4671-4d1d-7920-08dabd1031a2 - **Build**: 20221113.3 - **Date Produced**: November 14, 2022 3:19:03 AM UTC - **Commit**: cbfa5973058e8fad5e461e976ed821bc3ff6c313 - **Branch**: refs/heads/release/7.0.1xx - **Updates**: - **Microsoft.Dotnet.Sdk.Internal**: [from 7.0.101-servicing.22559.16 to 7.0.101-servicing.22563.3][6] - **Microsoft.AspNetCore.App.Ref**: [from 7.0.0-rtm.22512.1 to 7.0.0][7] [6]: dotnet/installer@c467942...cbfa597 [7]: https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore/branches?baseVersion=GCc686535&targetVersion=GCbb01bbf&_a=files ## Coherency Updates The following updates ensure that dependencies with a *CoherentParentDependency* attribute were produced in a build used as input to the parent dependency's build. See [Dependency Description Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview) - **Coherency Updates**: - **Microsoft.AspNetCore.App.Ref**: from 7.0.0-rtm.22512.1 to 7.0.0 (parent: Microsoft.Dotnet.Sdk.Internal) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions@xamarin.com> Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
This pull request updates the following dependencies ## Coherency Updates The following updates ensure that dependencies with a *CoherentParentDependency* attribute were produced in a build used as input to the parent dependency's build. See [Dependency Description Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview) - **Coherency Updates**: - **Microsoft.NET.Workload.Emscripten.net7.Manifest-7.0.100**: from 7.0.0 to 7.0.1 (parent: Microsoft.NETCore.App.Ref) ## From https://github.com/dotnet/runtime - **Subscription**: 38d2313f-22d5-4062-c8e1-08dabd6d8c77 - **Build**: 20221111.7 - **Date Produced**: November 12, 2022 12:29:45 AM UTC - **Commit**: 12b1873d69d9d97aaaa3ed97cfa93657ad6f7f39 - **Branch**: refs/heads/release/7.0 - **Updates**: - **Microsoft.NETCore.App.Ref**: [from 7.0.1 to 7.0.1][5] - **Microsoft.NET.Workload.Emscripten.net7.Manifest-7.0.100**: [from 7.0.0 to 7.0.1][6] [5]: dotnet/runtime@96c24ea...12b1873 [6]: dotnet/emsdk@6b7d1f4...3a6c724 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…Intents, JavaScriptCore, LocalAuthentication, MLCompute, MapKit, MediaAccessibility, MediaLibrary, MediaPlayer and MediaToolbox frameworks. (dotnet#16755)
…rin/maccore@2626. (dotnet#16743) Ignore certificate chain errors on bots in MessageHandlerTest.RejectSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler. Fixes xamarin/maccore#2626.
…e an assembly reference. (dotnet#16750)
… threadpool threads. Fixes dotnet#11788. (dotnet#16751) MonoVM in .NET 6+ supports automatic autorelease pools on threadpool threads just like CoreCLR does, so we can remove our custom mono profiler hooks to accomplish this. Fixes dotnet#11788.
Part of dotnet#14489. Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
There's no need to: * Check for HD space. * Make mlaunch verbose. * Reset launchctl. if something else already went wrong in a test run.
…otnet#16765) Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…t#16732) Changing properties to be internal Fixes dotnet#16665 Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…, SystemConfiguration, TVServices, VideoToolbox, Vision and WKWebKit frameworks. (dotnet#16763)
…dotnet#16762) When the autoformatter runs into the '%...%' pattern in *.cs files, it will re-format the text (to '% ... %'), but that breaks our text replacement logic. So instead use a valid C# identifier as a replacement token, in which case the autoformatter won't confuse our replacement logic.
…nto it. (dotnet#16757) Fixes this random build error: /bin/sh: Workloads/Microsoft.NET.Sdk.macOS/WorkloadManifest.targets.tmp: No such file or directory make[1]: *** [Workloads/Microsoft.NET.Sdk.macOS/WorkloadManifest.targets] Error 1 make[1]: *** Waiting for unfinished jobs....
…ry.GetPasses returns null. Fixes #xamarin/maccore@2598. (dotnet#16738) PKPassLibrary.GetPasses randomly returns null for no apparent rhyme or reason on our bots, so just ignore the test in that case. Maybe if someone can reproduce locally one day we'll be able to investigate and figure out what's happening. Fixes xamarin/maccore#2598.
Fixes these warnings:
appkit.cs(13128,8): warning CS0108: 'NSResponder.RestoreUserActivityState(NSUserActivity)' hides inherited member 'NSUserActivityRestoring.RestoreUserActivityState(NSUserActivity)'. Use the new keyword if hiding was intended.
appkit.cs(19500,12): warning CS0109: The member 'NSTextView.Editable' does not hide an accessible member. The new keyword is not required.
appkit.cs(19503,12): warning CS0109: The member 'NSTextView.Selectable' does not hide an accessible member. The new keyword is not required.
appkit.cs(27481,14): warning CS0108: 'NSFontAssetRequest.Progress' hides inherited member 'NSProgressReporting.Progress'. Use the new keyword if hiding was intended.
appkit.cs(5342,8): warning CS0108: 'NSController.DiscardEditing()' hides inherited member 'NSEditor.DiscardEditing()'. Use the new keyword if hiding was intended.
appkit.cs(5346,8): warning CS0108: 'NSController.CommitEditing(NSObject, Selector, nint)' hides inherited member 'NSEditor.CommitEditing(NSObject, Selector, nint)'. Use the new keyword if hiding was intended.
appkit.cs(5353,8): warning CS0108: 'NSController.ObjectDidBeginEditing(INSEditor)' hides inherited member 'NSEditorRegistration.ObjectDidBeginEditing(INSEditor)'. Use the new keyword if hiding was intended.
appkit.cs(5356,8): warning CS0108: 'NSController.ObjectDidEndEditing(INSEditor)' hides inherited member 'NSEditorRegistration.ObjectDidEndEditing(INSEditor)'. Use the new keyword if hiding was intended.
appkit.cs(5367,8): warning CS0108: 'NSController.CommitEditing()' hides inherited member 'NSEditor.CommitEditing()'. Use the new keyword if hiding was intended.
appkit.cs(5974,8): warning CS0108: 'NSDocument.ValidateUserInterfaceItem(INSValidatedUserInterfaceItem)' hides inherited member 'NSUserInterfaceValidations.ValidateUserInterfaceItem(INSValidatedUserInterfaceItem)'. Use the new keyword if hiding was intended.
appkit.cs(6113,8): warning CS0108: 'NSDocument.RestoreUserActivityState(NSUserActivity)' hides inherited member 'NSUserActivityRestoring.RestoreUserActivityState(NSUserActivity)'. Use the new keyword if hiding was intended.
appkit.cs(6260,8): warning CS0108: 'NSDocumentController.ValidateUserInterfaceItem(INSValidatedUserInterfaceItem)' hides inherited member 'NSUserInterfaceValidations.ValidateUserInterfaceItem(INSValidatedUserInterfaceItem)'. Use the new keyword if hiding was intended.
avfoundation.cs(4928,3): warning CS0618: 'AVSampleCursorSyncInfo' is obsolete: 'This API is not available on this platform.'
avfoundation.cs(4931,3): warning CS0618: 'AVSampleCursorSyncInfo' is obsolete: 'This API is not available on this platform.'
avfoundation.cs(4942,3): warning CS0618: 'AVSampleCursorStorageRange' is obsolete: 'This API is not available on this platform.'
avfoundation.cs(4945,3): warning CS0618: 'AVSampleCursorChunkInfo' is obsolete: 'This API is not available on this platform.'
avfoundation.cs(4951,3): warning CS0618: 'AVSampleCursorStorageRange' is obsolete: 'This API is not available on this platform.'
carplay.cs(1622,8): warning CS0108: 'CPListImageRowItem.Enabled' hides inherited member 'CPListTemplateItem.Enabled'. Use the new keyword if hiding was intended.
carplay.cs(1695,8): warning CS0108: 'CPMessageListItem.Enabled' hides inherited member 'CPListTemplateItem.Enabled'. Use the new keyword if hiding was intended.
carplay.cs(576,8): warning CS0108: 'CPListItem.Enabled' hides inherited member 'CPListTemplateItem.Enabled'. Use the new keyword if hiding was intended.
contacts.cs(1589,3): warning CS0618: 'CategoryAttribute.CategoryAttribute(bool)' is obsolete: 'Inline the static members in this category in the category's class (and remove this obsolete once fixed)'
contacts.cs(1685,3): warning CS0618: 'CategoryAttribute.CategoryAttribute(bool)' is obsolete: 'Inline the static members in this category in the category's class (and remove this obsolete once fixed)'
coredata.cs(1053,12): warning CS0109: The member 'NSManagedObjectContext.Lock()' does not hide an accessible member. The new keyword is not required.
coredata.cs(1059,12): warning CS0109: The member 'NSManagedObjectContext.Unlock()' does not hide an accessible member. The new keyword is not required.
coredata.cs(2066,12): warning CS0109: The member 'NSPersistentStoreCoordinator.Lock()' does not hide an accessible member. The new keyword is not required.
coredata.cs(2072,12): warning CS0109: The member 'NSPersistentStoreCoordinator.Unlock()' does not hide an accessible member. The new keyword is not required.
coreimage.cs(1731,88): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
coreimage.cs(1798,81): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
foundation.cs(459,21): error CS0246: The type or namespace name 'NSTextBlock' could not be found (are you missing a using directive or an assembly reference?)
foundation.cs(463,21): error CS0246: The type or namespace name 'NSTextTable' could not be found (are you missing a using directive or an assembly reference?)
gamecontroller.cs(2422,13): warning CS0108: 'GCDevicePhysicalInput.Device' hides inherited member 'GCDevicePhysicalInputState.Device'. Use the new keyword if hiding was intended.
healthkit.cs(4208,237): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
healthkit.cs(4208,247): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
mapkit.cs(1892,12): warning CS0109: The member 'MKTileOverlay.CanReplaceMapContent' does not hide an accessible member. The new keyword is not required.
metal.cs(1627,3): warning CS0618: 'MTLAccelerationStructureSizes' is obsolete: 'This API is not available on this platform.'
notificationcenter.cs(82,3): warning CS0618: 'CategoryAttribute.CategoryAttribute(bool)' is obsolete: 'Inline the static members in this category in the category's class (and remove this obsolete once fixed)'
PassKit/PKEnums.cs(193,11): warning CS0618: 'PKPaymentButtonType.Checkout' is obsolete: 'Use 'Checkout2'.'
PassKit/PKEnums.cs(195,15): warning CS0618: 'PKPaymentButtonType.Book' is obsolete: 'Use 'Book2'.'
pdfkit.cs(1454,76): warning CS0618: 'PdfPrintScalingMode' is obsolete: 'This type is not available on iOS.'
pdfkit.cs(2020,53): warning CS0618: 'PdfPrintScalingMode' is obsolete: 'This type is not available on iOS.'
scenekit.cs(1973,87): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
sharedwithyou.cs(372,9): warning CS0108: 'SWHighlightChangeEvent.HighlightUrl' hides inherited member 'SWHighlightEvent.HighlightUrl'. Use the new keyword if hiding was intended.
soundanalysis.cs(207,4): warning CS0657: 'return' is not a valid attribute location for this declaration. Valid attribute locations for this declaration are 'property'. All attributes in this block will be ignored.
uikit.cs(11490,44): warning CS0109: The member 'UIResponder.ActivityItemsConfiguration' does not hide an accessible member. The new keyword is not required.
uikit.cs(11505,18): warning CS0109: The member 'UIResponder.TouchBar' does not hide an accessible member. The new keyword is not required.
uikit.cs(11509,14): warning CS0108: 'UIResponder.TouchBar' hides inherited member 'NSTouchBarProvider.TouchBar'. Use the new keyword if hiding was intended.
uikit.cs(292,3): warning CS0618: 'CategoryAttribute.CategoryAttribute(bool)' is obsolete: 'Inline the static members in this category in the category's class (and remove this obsolete once fixed)'
usernotifications.cs(197,13): warning CS0618: 'UNNotificationInterruptionLevel.Critical' is obsolete: 'Use 'Critical2'.'
usernotifications.cs(198,15): warning CS0618: 'UNNotificationInterruptionLevel.TimeSensitive' is obsolete: 'Use 'TimeSensitive2'.'
usernotifications.cs(199,14): warning CS0618: 'UNNotificationInterruptionLevel.Active' is obsolete: 'Use 'Active2'.'
usernotifications.cs(200,20): warning CS0618: 'UNNotificationInterruptionLevel.Passive' is obsolete: 'Use 'Passive2'.'
xkit.cs(2068,15): warning CS0109: The member 'NSCollectionLayoutVisibleItem.Center' does not hide an accessible member. The new keyword is not required.
xkit.cs(2073,14): warning CS0109: The member 'NSCollectionLayoutVisibleItem.Bounds' does not hide an accessible member. The new keyword is not required.
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…otnet#16709) * Print the load average every 15 minutes. Also print a full process list if the load average > 10. * Print a full process list of the system every hour. * Print a summary to stdout at the end of the test run. Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
This pull request updates the following dependencies ## From https://github.com/dotnet/installer - **Subscription**: 50c9492e-4671-4d1d-7920-08dabd1031a2 - **Build**: 20221115.2 - **Date Produced**: November 15, 2022 5:40:05 PM UTC - **Commit**: d62cd319ad79088d6075221e8edf36913af24e33 - **Branch**: refs/heads/release/7.0.1xx - **Updates**: - **Microsoft.Dotnet.Sdk.Internal**: [from 7.0.101-servicing.22563.3 to 7.0.101-servicing.22565.2][2] [2]: dotnet/installer@cbfa597...d62cd31 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…options:documentAttributes:error:]'. (dotnet#16787) The 'initWithFileURL:options:documentAttributes:error:' was deprecated in iOS 9, and a new alternative (initWithURL:options:documentAttributes:error:) was added. At the time, we implemented automatic detection of the current OS, and would choose one version or the other depending on which was available. We won't support anything below iOS 9 anymore, which means that keeping the backwards-compatible constructor is useless, so just remove the corresponding code and expose the new alternative directly. On another note, this constructor uses a 'ref NSError' argument instead of an 'out NSError' on mobile platforms (likely due to the generator not having proper 'out' parameter support when this constructor was implemented), so improve to use 'out' parameters in XAMCORE_5_0 (and macOS, where it already uses 'out' parameters). Ref: dotnet#15216
Unify the code for the following functions: * NSAttributedString.GetData[FromRange] * NSAttributedString.GetFileWrapper[FromRange] These functions use 'ref' arguments instead of 'out' arguments for mobile platforms (likely due to the generator not having proper 'out' parameter support when these functions were implemented), so improve to use 'out' parameters in XAMCORE_5_0 (and macOS, where they already use 'out' parameters). Also fix nullability. Ref: dotnet#15216
…ibraryResources target. Fixes dotnet#16377. (dotnet#16416) Fixes dotnet#16377 MSbuild has the ability to run `Target` partially. However in order to make sure we can use this, both the `Inputs` and `Outputs` need to have a 1-1 mapping. MSBuild will then use this mapping to figure out which files have actually changed. Then it will call the Target with only those files. In Xamarin.Android we make use of stamp files to provide this 1-1 mapping. We have a `pre` Target which will calculate an ItemGroup which will include a StampFile piece of metadata. We then use this new ItemGroup for both the `Inputs` and `Outputs`, thus meeting the 1-1 requirement. This PR updates the `_UnpackLibraryResources` to run partially. This will hopefully reduce the build time on incremental builds.
The `Delete` task should not need to copy any files to the remote server. Lets try to set this up by implementing the `ShouldCopyToBuildServer` method. This should help reduce build times if it works.
…r not. (dotnet#16771) Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…of delegates for our native->managed bridge. (dotnet#16702) Use function pointers to our managed callbacks instead of delegates for the native->managed bridge. This makes execution faster on AOT (because the AOT compiler can just emit the native function address, no need to go through the expensive marshalling machinery). This involved a few changes to make the managed callbacks only use blittable types in the function signature: * Use `sbyte` / `int8_t` instead of `bool`. * Use pointers instead of `out`/`ref` arguments. * Use `IntPtr` instead of `string` arguments. The code rarely shows up in timing profiles before the change, and never after. This means that time-wise this doesn't save all that much, because there wasn't much to gain to begin with (but it's still a gain). Memory-wise, we're now allocation 0,19 MiB less on startup (17,61 MiB vs 17,42 MiB).
…version is >= 11.0 (dotnet#16746) There are no changes for 32-bit watchOS, because watchOS support is likely to go away completely anyways.
…otnet#16749) Change the static registrar to fail gracefully if it can't compute a metadata token for a given metadata item, and instead fall back to doing the lookup of whatever we need at runtime. This is a step towards making per-assembly static registrar working. Ref: dotnet#12067. Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…16777) [SWCollaborationView setDelegate:] crashes when passed null. Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…nto it. (dotnet#16778) Fixes this random build error: cp: Workloads/Microsoft.NET.Sdk.tvOS/LICENSE: clonefile failed: No such file or directory make[1]: *** [Makefile:193: Workloads/Microsoft.NET.Sdk.tvOS/LICENSE] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/Users/rolf/work/maccore/dotnet/xamarin-macios/dotnet' Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
This pull request updates the following dependencies ## From https://github.com/dotnet/installer - **Subscription**: 50c9492e-4671-4d1d-7920-08dabd1031a2 - **Build**: 20221116.14 - **Date Produced**: November 16, 2022 11:48:39 PM UTC - **Commit**: 7a63b1bfae183bade22d4e67900f7d56745fa993 - **Branch**: refs/heads/release/7.0.1xx - **Updates**: - **Microsoft.Dotnet.Sdk.Internal**: [from 7.0.101-servicing.22565.2 to 7.0.101-servicing.22566.14][1] [1]: dotnet/installer@d62cd31...7a63b1b Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions@xamarin.com>
Collaborator
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
Collaborator
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
Collaborator
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 3 tests failed, 220 tests passed. Failures❌ cecil tests [attempt 2]Details
Html Report (VSDrops) Download ❌ dotnettests tests [attempt 2]Details
Html Report (VSDrops) Download ❌ msbuild tests [attempt 2]Details
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
tj-devel709
approved these changes
Nov 19, 2022
Member
Author
|
Test failures are unrelated (#16810, #16809, dotnet/runtime#78154) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.