[spritekit] Update for Xcode 8.3 beta 1 - part 2 - #1694
Merged
VincentDondain merged 2 commits intoFeb 15, 2017
Conversation
This is part 2 of dotnet#1628: "[spritekit] Update for iOS 10.3 beta 1" Thanks Tim for spotting these issues.
Contributor
|
Build failure |
Contributor
|
build |
Contributor
|
Build failure |
Contributor
|
This only covers part of Double-check the documentation but it seems that exposing the |
`attributeValues`, `valueForAttributeNamed:` & `setValue:forAttributeNamed:` should all be exposed because it would seem that the first one (`attributeValues`) is used to grab the values of **each attribute** associated with the node's attached shader. When the 2 others let you access the value of a given shader's attribute.
Contributor
Author
|
#1694 (comment) – all gone. I think we should expose |
spouliot
approved these changes
Feb 15, 2017
Contributor
|
Build failure |
Contributor
Author
|
Unrelated test failures: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 of #1628:
"[spritekit] Update for iOS 10.3 beta 1"
Thanks Tim for spotting these issues.