Skip to content

[spritekit] Update for Xcode 8.3 beta 1 - part 2 - #1694

Merged
VincentDondain merged 2 commits into
dotnet:xcode8.3from
VincentDondain:spritekit-b1-part2
Feb 15, 2017
Merged

[spritekit] Update for Xcode 8.3 beta 1 - part 2#1694
VincentDondain merged 2 commits into
dotnet:xcode8.3from
VincentDondain:spritekit-b1-part2

Conversation

@VincentDondain

Copy link
Copy Markdown
Contributor

This is part 2 of #1628:
"[spritekit] Update for iOS 10.3 beta 1"

Thanks Tim for spotting these issues.

This is part 2 of dotnet#1628:
"[spritekit] Update for iOS 10.3 beta 1"

Thanks Tim for spotting these issues.
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@spouliot

Copy link
Copy Markdown
Contributor

build

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@spouliot

Copy link
Copy Markdown
Contributor

This only covers part of

!missing-selector! SKEffectNode::attributeValues not bound
!missing-selector! SKEffectNode::setAttributeValues: not bound
!missing-selector! SKEffectNode::setValue:forAttributeNamed: not bound
!missing-selector! SKEffectNode::valueForAttributeNamed: not bound
!missing-selector! SKEmitterNode::attributeValues not bound
!missing-selector! SKEmitterNode::setAttributeValues: not bound
!missing-selector! SKEmitterNode::setValue:forAttributeNamed: not bound
!missing-selector! SKEmitterNode::valueForAttributeNamed: not bound
!missing-selector! SKShapeNode::attributeValues not bound
!missing-selector! SKShapeNode::setAttributeValues: not bound
!missing-selector! SKShapeNode::setValue:forAttributeNamed: not bound
!missing-selector! SKShapeNode::valueForAttributeNamed: not bound
!missing-selector! SKSpriteNode::attributeValues not bound
!missing-selector! SKSpriteNode::setAttributeValues: not bound
!missing-selector! SKSpriteNode::setValue:forAttributeNamed: not bound
!missing-selector! SKSpriteNode::valueForAttributeNamed: not bound
!missing-selector! SKTileMapNode::attributeValues not bound
!missing-selector! SKTileMapNode::setAttributeValues: not bound
!missing-selector! SKTileMapNode::setValue:forAttributeNamed: not bound
!missing-selector! SKTileMapNode::valueForAttributeNamed: not bound

Double-check the documentation but it seems that exposing the *:: attributeValues properties covers all cases. If that's the case then please update common.ignore for the rest. thanks!

@spouliot spouliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update xtro :)

`attributeValues`, `valueForAttributeNamed:` & `setValue:forAttributeNamed:` should all
be exposed because it would seem that the first one (`attributeValues`) is used to grab the values of **each attribute** associated with the node's attached shader.
When the 2 others let you access the value of a given shader's attribute.
@VincentDondain

Copy link
Copy Markdown
Contributor Author

#1694 (comment) – all gone.

I think we should expose *::setValue:forAttributeNamed: and *::valueForAttributeNamed:, see commit message.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@VincentDondain

Copy link
Copy Markdown
Contributor Author

Unrelated test failures:
iOS Unified 32 bit - https://bugzilla.xamarin.com/show_bug.cgi?id=52162

@VincentDondain
VincentDondain merged commit 4cd0b3b into dotnet:xcode8.3 Feb 15, 2017
@VincentDondain
VincentDondain deleted the spritekit-b1-part2 branch February 15, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants