Skip to content

[Generator] Remove method that is already present in the reflection API. - #17524

Merged
mandel-macaque merged 2 commits into
dotnet:mainfrom
mandel-macaque:remove-not-needed-method
Feb 14, 2023
Merged

[Generator] Remove method that is already present in the reflection API.#17524
mandel-macaque merged 2 commits into
dotnet:mainfrom
mandel-macaque:remove-not-needed-method

Conversation

@mandel-macaque

@mandel-macaque mandel-macaque commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque
mandel-macaque commented Feb 13, 2023
View reviewed changes
Comment thread tests/monotouch-test/CoreBluetooth/CentralManagerTest.cs
if (TestRuntime.IsInCI && TestRuntime.CheckXcodeVersion (14, 0))
TestRuntime.AssertNotDesktop (); // Looks like this particular test doesn't like Desktop + M1 bot machines
// iOS 13 and friends require bluetooth permission
// iOS 13 and friends require bluetooth permission

@mandel-macaque mandel-macaque Feb 13, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfbjarne ein?

@rolfbjarne rolfbjarne Feb 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added here: #17349, and autoformat disabled, so the change shows up in the next PR (yours)

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@mandel-macaque

mandel-macaque commented Feb 13, 2023

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Feb 13, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne
rolfbjarne approved these changes Feb 13, 2023
View reviewed changes
Comment thread tests/monotouch-test/CoreBluetooth/CentralManagerTest.cs
if (TestRuntime.IsInCI && TestRuntime.CheckXcodeVersion (14, 0))
TestRuntime.AssertNotDesktop (); // Looks like this particular test doesn't like Desktop + M1 bot machines
// iOS 13 and friends require bluetooth permission
// iOS 13 and friends require bluetooth permission

@rolfbjarne rolfbjarne Feb 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added here: #17349, and autoformat disabled, so the change shows up in the next PR (yours)

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 13, 2023

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 4bf99a27b0e392815261a02c992e1fd0eed186cd [PR build]

@mandel-macaque mandel-macaque changed the title [Generator] Remove method that is already represent in the reflection API. [Generator] Remove method that is already present in the reflection API. Feb 13, 2023
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 13, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 4bf99a27b0e392815261a02c992e1fd0eed186cd [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 13, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 4bf99a27b0e392815261a02c992e1fd0eed186cd [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 13, 2023

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1200.Monterey'
Hash: 4bf99a27b0e392815261a02c992e1fd0eed186cd [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Feb 13, 2023

Copy link
Copy Markdown
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 224 tests passed.

Failures

❌ xcframework tests

1 tests failed, 7 tests passed.
Details
  • xcframework-test/Mac Modern/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4bf99a27b0e392815261a02c992e1fd0eed186cd [PR build]

@mandel-macaque
mandel-macaque merged commit 498ced1 into dotnet:main Feb 14, 2023
@mandel-macaque
mandel-macaque deleted the remove-not-needed-method branch February 14, 2023 00:17
@rolfbjarne rolfbjarne mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes
+1 more reviewer
@haritha-mohan haritha-mohan haritha-mohan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mandel-macaque @vs-mobiletools-engineering-service2 @rolfbjarne @haritha-mohan