[tests] Fix NSTextInputClient tests on macOS Ventura. by rolfbjarne · Pull Request #17713 · dotnet/macios

rolfbjarne · 2023-03-06T10:23:14Z

Fixes:

apitest.NSTextInputClient
    [FAIL] NSTextInputClient_ShouldGetBaselineDelta :   NSTextInputClient_ShouldGetBaselineDelta - Returned wrong baseline delta value
        Expected: True
        But was:  False
          at apitest.NSTextInputClient.NSTextInputClient_ShouldGetBaselineDelta () [0x0000e] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppKit/NSTextInputClient.cs:108
    [FAIL] NSTextInputClient_ShouldGetFirstRect :   NSTextInputClient_ShouldGetFirstRect - Returned wrong rect
        Expected: {X=0,Y=0,Width=12,Height=14}
        But was:  {X=0,Y=0,Width=0,Height=14}
          at apitest.NSTextInputClient.NSTextInputClient_ShouldGetFirstRect () [0x00030] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppKit/NSTextInputClient.cs:84

Fixes: apitest.NSTextInputClient [FAIL] NSTextInputClient_ShouldGetBaselineDelta : NSTextInputClient_ShouldGetBaselineDelta - Returned wrong baseline delta value Expected: True But was: False at apitest.NSTextInputClient.NSTextInputClient_ShouldGetBaselineDelta () [0x0000e] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppKit/NSTextInputClient.cs:108 [FAIL] NSTextInputClient_ShouldGetFirstRect : NSTextInputClient_ShouldGetFirstRect - Returned wrong rect Expected: {X=0,Y=0,Width=12,Height=14} But was: {X=0,Y=0,Width=0,Height=14} at apitest.NSTextInputClient.NSTextInputClient_ShouldGetFirstRect () [0x00030] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppKit/NSTextInputClient.cs:84

This reverts commit c2810ab.

vs-mobiletools-engineering-service2 · 2023-03-06T14:52:31Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 7bbb13f7a3a1ead13986fbf822285b877b6e05ae [PR build]

vs-mobiletools-engineering-service2 · 2023-03-06T14:53:51Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1189.Monterey'
Hash: 7bbb13f7a3a1ead13986fbf822285b877b6e05ae [PR build]

vs-mobiletools-engineering-service2 · 2023-03-06T14:55:14Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 7bbb13f7a3a1ead13986fbf822285b877b6e05ae [PR build]

vs-mobiletools-engineering-service2 · 2023-03-06T15:07:08Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 7bbb13f7a3a1ead13986fbf822285b877b6e05ae [PR build]

vs-mobiletools-engineering-service2 · 2023-03-07T00:55:03Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 224 tests passed.

Failures

❌ monotouch tests [attempt 2]

1 tests failed, 24 tests passed.

Details

monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7bbb13f7a3a1ead13986fbf822285b877b6e05ae [PR build]

rolfbjarne · 2023-03-07T06:47:22Z

Test failure is unrelated (#17649).

rolfbjarne · 2023-03-07T06:47:51Z

/sudo backport release/7.0.2xx

rolfbjarne · 2023-03-07T06:47:59Z

/sudo backport release/7.0.1xx-xcode14.2

rolfbjarne · 2023-03-07T06:48:07Z

/sudo backport release/6.0.4xx-xcode14.2

vs-mobiletools-engineering-service2 · 2023-03-07T06:48:12Z

Backport Job to branch release/7.0.2xx Created! The magic is happening here

rolfbjarne · 2023-03-07T06:48:12Z

/sudo backport xcode14.2

vs-mobiletools-engineering-service2 · 2023-03-07T06:48:21Z

Backport Job to branch release/7.0.1xx-xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-03-07T06:48:25Z

Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-03-07T06:48:32Z

Backport Job to branch xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-03-07T06:50:08Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7431432 for more details.

vs-mobiletools-engineering-service2 · 2023-03-07T06:50:16Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7431431 for more details.

vs-mobiletools-engineering-service2 · 2023-03-07T06:50:25Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7431433 for more details.

vs-mobiletools-engineering-service2 · 2023-03-07T06:50:42Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7431434 for more details.

Fixes: apitest.NSTextInputClient [FAIL] NSTextInputClient_ShouldGetBaselineDelta : NSTextInputClient_ShouldGetBaselineDelta - Returned wrong baseline delta value Expected: True But was: False at apitest.NSTextInputClient.NSTextInputClient_ShouldGetBaselineDelta () [0x0000e] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppKit/NSTextInputClient.cs:108 [FAIL] NSTextInputClient_ShouldGetFirstRect : NSTextInputClient_ShouldGetFirstRect - Returned wrong rect Expected: {X=0,Y=0,Width=12,Height=14} But was: {X=0,Y=0,Width=0,Height=14} at apitest.NSTextInputClient.NSTextInputClient_ShouldGetFirstRect () [0x00030] in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppKit/NSTextInputClient.cs:84

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits March 6, 2023 13:58

Revert "[tests] Fix NSTextInputClient tests on macOS Ventura."

29112c3

This reverts commit c2810ab.

Try to make it work for both xammac tests and monotouch-test.

7bbb13f

tj-devel709 approved these changes Mar 6, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

haritha-mohan approved these changes Mar 6, 2023

View reviewed changes

dalexsoto approved these changes Mar 7, 2023

View reviewed changes

rolfbjarne merged commit 666bd9a into dotnet:main Mar 7, 2023

rolfbjarne deleted the fix-ventura-xammac-tests branch March 7, 2023 06:47

rolfbjarne mentioned this pull request Mar 13, 2023

[net8.0] Merge main into net8.0. #17753

Merged

Uh oh!

Conversation

rolfbjarne commented Mar 6, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 6, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 6, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 6, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 6, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 7, 2023

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ monotouch tests [attempt 2]

Successes

Uh oh!

rolfbjarne commented Mar 7, 2023

Uh oh!

rolfbjarne commented Mar 7, 2023

Uh oh!

rolfbjarne commented Mar 7, 2023

Uh oh!

rolfbjarne commented Mar 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 7, 2023

Uh oh!

rolfbjarne commented Mar 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants