Skip to content

[net8.0] Merge main into net8.0. - #17753

Merged
rolfbjarne merged 6 commits into
dotnet:net8.0from
rolfbjarne:bump-main-in-net8.0-2023-03-08
Mar 13, 2023
Merged

[net8.0] Merge main into net8.0.#17753
rolfbjarne merged 6 commits into
dotnet:net8.0from
rolfbjarne:bump-main-in-net8.0-2023-03-08

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Mar 8, 2023

Copy link
Copy Markdown
Member

No description provided.

rolfbjarne and others added 6 commits March 7, 2023 18:58
@rolfbjarne
[dotnet] Change _IntermediateDecompressionDir to always have a traili…
256ef1c 
…ng directory separator. (dotnet#17728)

Also don't hardcode the trailing directory separator as a forward slash,
because we might be executing on Windows (which is the real purpose behind
this change).
@rolfbjarne
[tests] Use Path.Combine instead of hardcoding '/'. (dotnet#17733)
d1804f5
@rolfbjarne
[monotouch-test] Fix bool encoding in tests on ARM64 on Mac Catalyst. (…
d6d02fa 
…dotnet#17695)

Fixes:

    [FAIL] TestTypeEncodings :   dotnet#14
        String lengths are both 1. Strings differ at index 0.
        Expected: "B"
        But was:  "c"
        -----------^
@mandel-macaque
[CI] Allow to debug the env in the upload jobs. (dotnet#17724)
bf32e85
@stephen-hawley
[dotnet] future proof the test (dotnet#17739)
4c1e568 
Add documentation in case of future test fails
@rolfbjarne
[net8.0] Merge main into net8.0.
69f5c42
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 69f5c42db4f5db269b96903afafc04057603ea69 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • xammac_tests

Pipeline on Agent
Hash: 69f5c42db4f5db269b96903afafc04057603ea69 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 69f5c42db4f5db269b96903afafc04057603ea69 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1043.Monterey'
Hash: 69f5c42db4f5db269b96903afafc04057603ea69 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 219 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 69f5c42db4f5db269b96903afafc04057603ea69 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • xammac_tests

Pipeline on Agent
Hash: 69f5c42db4f5db269b96903afafc04057603ea69 [PR build]

@rolfbjarne

rolfbjarne commented Mar 13, 2023

Copy link
Copy Markdown
Member Author

Test failure is unrelated (#17713).

@rolfbjarne
rolfbjarne merged commit 16f5237 into dotnet:net8.0 Mar 13, 2023
@rolfbjarne
rolfbjarne deleted the bump-main-in-net8.0-2023-03-08 branch March 13, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@tj-devel709 tj-devel709 tj-devel709 approved these changes
+3 more reviewers
@mandel-macaque mandel-macaque mandel-macaque approved these changes
@stephen-hawley stephen-hawley stephen-hawley approved these changes
@haritha-mohan haritha-mohan haritha-mohan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque @stephen-hawley @tj-devel709 @haritha-mohan