Skip to content

[msbuild] Always codesign app bundles if the codesign key is non-null - #2683

Closed
jstedfast wants to merge 1 commit into
masterfrom
msbuild-59379
Closed

[msbuild] Always codesign app bundles if the codesign key is non-null#2683
jstedfast wants to merge 1 commit into
masterfrom
msbuild-59379

Conversation

@jstedfast

Copy link
Copy Markdown
Member

...even if it is a simulator build.

Turns out that starting with Xcode9, sim builds need to be codesigned
for App Groups entitlements to work properly. Interestingly, the
DetectSigningIdentity logic had a comment about needing to codesign
simulator builds for some entitlements to work already starting with
Xcode 8 but apparently the iOS targets did not respect this.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=59379

...even if it is a simulator build.

Turns out that starting with Xcode9, sim builds need to be codesigned
for App Groups entitlements to work properly. Interestingly, the
DetectSigningIdentity logic had a comment about needing to codesign
simulator builds for some entitlements to work already starting with
Xcode 8 but apparently the iOS targets did not respect this.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=59379
@jstedfast

Copy link
Copy Markdown
Member Author

It should be noted that based on my tinkering around yesterday, it seems that Xcode9 always codesigns simulator builds and it's not based on what entitlements are enabled or anything like that.

Based on a comment in DetectSigningIdentity, it seems that it might be that way for Xcode8 as well but I have not verified that yet (will be doing shortly and adding a follow-up comment with my findings).

@jstedfast jstedfast added the do-not-merge Do not merge this pull request label Sep 13, 2017
@jstedfast

Copy link
Copy Markdown
Member Author

afaict, Xcode8 always seems to codesign sim builds as well.

@monojenkins

Copy link
Copy Markdown
Contributor

Build success

@rolfbjarne rolfbjarne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, except that I think it should go into the xcode9 branch instead, otherwise it will take a while before customers get this fix.

@jstedfast

jstedfast commented Sep 14, 2017

Copy link
Copy Markdown
Member Author

@rolfbjarne ok, I'll submit a PR against xcode9. I wasn't sure which branch I should make it against before :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do not merge this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants