[msbuild] Always codesign app bundles if the codesign key is non-null - #2697
Merged
Conversation
...even if it is a simulator build. Turns out that starting with Xcode9, sim builds need to be codesigned for App Groups entitlements to work properly. Interestingly, the DetectSigningIdentity logic had a comment about needing to codesign simulator builds for some entitlements to work already starting with Xcode 8 but apparently the iOS targets did not respect this. Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=59379
jstedfast
requested review from
VincentDondain,
emaf,
rolfbjarne and
spouliot
September 14, 2017 14:34
Member
Author
|
This is the same patch as the one in #2683 |
emaf
approved these changes
Sep 14, 2017
rolfbjarne
approved these changes
Sep 14, 2017
Contributor
|
Build success |
VincentDondain
approved these changes
Sep 14, 2017
spouliot
reviewed
Sep 14, 2017
spouliot
left a comment
spouliot
left a comment
Contributor
There was a problem hiding this comment.
@jstedfast I’m assuming _CodeSigningKey is not empty when we have "Developer (automatic)" in the settings, right ?
So does this force signing all the time ? for all projects ?
because it's a significant impact in simulator build times :(
spouliot
approved these changes
Sep 14, 2017
spouliot
left a comment
spouliot
left a comment
Contributor
There was a problem hiding this comment.
https://xamarinhq.slack.com/archives/C03CCJNR7/p1505406722000223
TL&DR a special - key is used when none is available and codesign accept this
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Aug 23, 2023
Bump maccore to bing the changes for governance and some others: * Merge 'xcode15' into 'main'. (dotnet#2690) * [Submission] Add NotaryTool Task (dotnet#2689) * [XmlDocSync] Remove the XmlDocSync reference from the project. (dotnet#2693) * [mlaunch] Refactor project structure (dotnet#2694) * [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12 (dotnet#2697) * [Governance] Update the false positives files based on the last runs. (dotnet#2698) Full idff: https://github.com/xamarin/maccore/compare/fd15821e6780a7439df467c69eb511a046adfa06...63fd14954ca3328219c5f79c754f0b329091535c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...even if it is a simulator build.
Turns out that starting with Xcode9, sim builds need to be codesigned
for App Groups entitlements to work properly. Interestingly, the
DetectSigningIdentity logic had a comment about needing to codesign
simulator builds for some entitlements to work already starting with
Xcode 8 but apparently the iOS targets did not respect this.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=59379