[scenekit] SCNPhysicsShape's Create should take a SCNMatrix4 array, not SCNVector3

[VincentDondain]

• Fixes SCNPhysicsShape.Create transforms param is bound incorrectly #4030: SCNPhysicsShape.Create transforms param is bound incorrectly
  (SCNPhysicsShape.Create transforms param is bound incorrectly #4030)

[monojenkins]

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 79 tests passed.

Failed tests

• monotouch-test/watchOS - simulator/Debug: Failed

---

[VincentDondain]

Known issue: MessageHandlerTest.DnsFailure https://github.com/xamarin/maccore/issues/701

[rolfbjarne]

@VincentDondain this introduces a breaking change:

Type Changed: SceneKit.SCNPhysicsShape

Removed method:
-public static SCNPhysicsShape Create (SCNPhysicsShape[] shapes, SCNVector3[] transforms);

Added method:
+public static SCNPhysicsShape Create (SCNPhysicsShape[] shapes, SCNMatrix4[] transforms);

[VincentDondain]

@rolfbjarne fixed in #4126, I missed the !

However we should fix the report for API diff #4040 (comment), it should have failed.

[rolfbjarne]

However we should fix the report for API diff #4040 (comment), it should have failed.

That's not as easy to automate as it sounds 😒
We could show that there were breaking changes (but not automatically fail the build, because there might be changes that are acceptable, or the tool detects incorrectly).

[VincentDondain]

@rolfbjarne shouldn't "API Diff (from PR only)" fail the build? If we want we can always justify and merge anyway. Subsequent PRs shouldn't fail because the breaking change would then end up in "API Diff (from stable)" and we wouldn't make this one fail the build.

In any case I think "API Diff (from PR only)" should at least show 🔥 if there breaking changes.