Skip to content

[scenekit] SCNPhysicsShape's Create should take a SCNMatrix4 array, not SCNVector3 #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentDondain merged 1 commit into from
May 7, 2018
Merged

[scenekit] SCNPhysicsShape's Create should take a SCNMatrix4 array, not SCNVector3 #4040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/SceneKit/SCNPhysicsShape.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,23 @@ namespace SceneKit
{
public partial class SCNPhysicsShape
{
public static SCNPhysicsShape Create (SCNPhysicsShape [] shapes, SCNMatrix4 [] transforms)
{
if (shapes == null)
throw new ArgumentNullException ("shapes");

if (transforms == null)
throw new ArgumentNullException ("transforms");

var t = new NSValue [transforms.Length];
for (var i = 0; i < t.Length; i++)
t [i] = NSValue.FromSCNMatrix4 (transforms [i]);

return Create (shapes, t);
}

#if XAMCORE_4_0
[Obsolete ("Use the 'Create' method that takes a 'SCNMatrix4 []'.")]
public static SCNPhysicsShape Create (SCNPhysicsShape [] shapes, SCNVector3 [] transforms)
{
if (shapes == null)
Expand All @@ -31,6 +48,7 @@ public static SCNPhysicsShape Create (SCNPhysicsShape [] shapes, SCNVector3 [] t

return Create (shapes, t);
}
#endif

public static SCNPhysicsShape Create (SCNGeometry geometry,
SCNPhysicsShapeType? shapeType = null,
Expand Down