Bump to mono:2018-08 by directhex · Pull Request #4596 · dotnet/macios

directhex · 2018-08-08T16:23:14Z

No description provided.

`mono_jit_set_aot_only` is deprecated and accidentally broke with mono/mono#7887 This should fix device tests with `mono-2018-06`

Commit list for mono/mono: * mono/mono@7bcda192a06 Bump llvm to release_60/fc854b8ec5873d294b80afa3e6cf6a88c5c48886. (#9786). (#9804) * mono/mono@23e95ec7ad7 Apply F# portable pdb debug fix for pinvokes & bump (#9797) * mono/mono@295f6d32afd [2018-06] [MacOS] On Mac, use the copyfile API to copy files (#9696) Diff: mono/mono@7d5f4b6...7bcda19

Starting with mono 5.16 mcs will now add assembly references when the assembly is only used in attributes (this was already the case for csc in both 5.14 and 5.16, so it seems to be a compatibility change). Adjust the MT0137 test accordingly.

…s in the error message. Fixes this test: 1) Test Failure : Xamarin.iOS.Tasks.Bug60536.TestACToolTaskCatchesJsonException ColumnNumber Expected: 2 But was: 0

… mono-2018-06

…make the 32 bit builds use that.

xamarin-release-manager · 2018-11-20T15:36:58Z

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Package XM tests' 🔥

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (no change)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

monojenkins · 2018-11-20T19:53:08Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

3 tests failed, 0 tests skipped, 281 tests passed.

Failed tests

apitest/Mac Classic/NonSystem: Failed (Test run crashed (exit code: 134).)
Xtro/Mac: Failed (Test run failed.)
monotouch-test/watchOS - simulator/Debug: Crashed

rolfbjarne · 2018-11-21T11:31:14Z

Test failures on internal jenkins are unrelated:

Package XM tests: https://github.com/xamarin/maccore/issues/1169

Test failures on public jenkins are unrelated:

apitest/Classic: https://github.com/xamarin/maccore/issues/643
xtro: https://github.com/xamarin/maccore/issues/1170
monotouch-test/watchOS: https://github.com/xamarin/maccore/issues/581

rolfbjarne · 2018-11-21T11:31:23Z

@marek-safar there's an API break in mscorlib, is this expected?

marek-safar · 2018-11-22T16:55:11Z

Yes, this is expected. We had discussed it with XA in previous integration (this is not new in 2018-08). See for more details dotnet/android#1836 (comment) but in short, this is an infrastructure code removed bu CoreFX folks which was not intended to be used by users.

rolfbjarne · 2018-11-23T15:10:53Z

I ran some of the device tests locally, and found that:

iOS and tvOS tests run fine.
watchOS is completely broken due to watchOS extensions crash at launch with 'Failed to load AOT module 'mscorlib' while running in aot-only mode: not compiled with safepoints.' mono/mono#11765.

xamarin-release-manager · 2018-11-26T08:49:42Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.9'' 🔥 : hudson.AbortException: Xamarin.Mac tests on macOS 10.9 failed (introspection, xammac_tests)

✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
✅ Generator Diff (no change)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.
🔥 Xamarin.Mac tests on macOS 10.9 failed (introspection, xammac_tests) 🔥

monojenkins · 2018-11-26T13:26:57Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

2 tests failed, 0 tests skipped, 282 tests passed.

Failed tests

mmptest/macOS/NonSystem: Failed (Execution failed with exit code 2)
MMP Regression Tests/Mac: Failed

rolfbjarne · 2018-11-26T13:43:01Z

Test failures on internal Jenkins are unrelated:

Running XM tests on '10.9'
- introspection: https://github.com/xamarin/maccore/issues/1176
- xammac tests: https://github.com/xamarin/maccore/issues/1177

Test failures on public Jenkins are unrelated:

mmptest: https://github.com/xamarin/maccore/issues/1175
mmp regression tests: https://github.com/xamarin/maccore/issues/1174

GouriKumari · 2018-11-26T14:24:31Z

Sample building tests for XI and XM are executed successfully with mono2018-08 branch. IDE integration tests are also executed against the mono2018-08 branch. Failures are all known issues and not related mono2018-08.

…alling the AOT compiler. Works around mono/mono#11765. Visual Studio for Mac may set MONO_THREADS_SUSPEND, and this ends up confusing the AOT compiler when compiling for watchOS. So unset the environment variable before calling the AOT compiler. Works around mono/mono#11765.

xamarin-release-manager · 2018-11-27T12:15:08Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.9'' 🔥 : hudson.AbortException: Xamarin.Mac tests on macOS 10.9 failed (introspection, xammac_tests)

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (no change)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.
🔥 Xamarin.Mac tests on macOS 10.9 failed (introspection, xammac_tests) 🔥

marek-safar · 2018-11-27T15:44:07Z

@spouliot are we ready or do we have to restart again because we now have conflict again?

spouliot · 2018-11-27T15:57:53Z

@marek-safar the conflict does not matter. We're waiting on the watchOS results - which tests restarted now that we have a workaround. @rolfbjarne will comment here with the results once the run is complete.

monojenkins · 2018-11-27T17:24:42Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

3 tests failed, 0 tests skipped, 281 tests passed.

Failed tests

monotouch-test/watchOS - simulator/Debug: Failed
mmptest/macOS/NonSystem: Failed (Execution failed with exit code 2)
MMP Regression Tests/Mac: Failed

rolfbjarne · 2018-11-27T18:14:40Z

The watchOS device tests ran fine (there were a few failing tests, but I ran the same tests with master and they failed there too, so they're not regressions. I'll file issues about these later).

The test failures from the latest comment from public Jenkins are unrelated:

monotouch-test/watchOS: https://github.com/xamarin/maccore/issues/701
mmptest/macOS/NonSystem: https://github.com/xamarin/maccore/issues/1175
mmp regression tests: https://github.com/xamarin/maccore/issues/1174

So this is good to go.

xamarin-release-manager · 2018-11-27T21:25:07Z

✅ Jenkins job (on internal Jenkins) succeeded

✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
✅ Generator Diff (no change)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

dalexsoto · 2018-11-27T22:04:21Z

✅ Api diff breaking changes are expected and unrelated to this PR, they come from the last merge of master due to acf8357.

Xamarin.Mac.dll

Namespace ObjCRuntime

Type Changed: ObjCRuntime.Constants

Modified fields:

-	public const string CFNetworkLibrary = "/System/Library/Frameworks/CFNetwork.framework/CFNetwork"
+	public const string CFNetworkLibrary = "/System/Library/Frameworks/CoreServices.framework/Frameworks/CFNetwork.framework/CFNetwork";

-	public const string CoreBluetoothLibrary = "/System/Library/Frameworks//CoreBluetooth.framework/CoreBluetooth"
+	public const string CoreBluetoothLibrary = "/System/Library/Frameworks/IOBluetooth.framework/Versions/A/Frameworks/CoreBluetooth.framework/CoreBluetooth";

monojenkins · 2018-11-28T00:29:17Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
✅ Test run succeeded

dalexsoto · 2018-12-05T15:48:04Z

@spouliot / @marek-safar it seems that https://github.com/mono/mono/commits/2018-08 has newer commits, do we want to bump this branch to the tip of https://github.com/mono/mono/commits/2018-08?

marek-safar · 2018-12-05T16:54:17Z

I'd prefer not to at this point, we are still waiting on XA to merge but once that happens we'll normal bump in master

spouliot · 2018-12-05T20:51:01Z

@dalexsoto thanks for noticing & pinging. Let's wait, as asked by @marek-safar, to minimize the number of moving parts.

luhenry · 2018-12-06T15:55:56Z

🎉

Jo Shields and others added 25 commits June 15, 2018 12:43

Bump to mono:2018-06

95bcaa9

Merge branch 'master' into mono-2018-06

69f8d32

Bump mono

8ad6666

Updates compression to work with the public span

e20975b

Bump mono

c044c6b

Fixes pointer check logic in Deflater

9935c1c

Bump mono

d5e029a

Fixes pointer check logic in Deflater

559ef82

Bump mono

8121c7b

Bump Mono

fe4b215

[runtime] always use mono_jit_set_aot_mode (#4491)

ce95d2a

`mono_jit_set_aot_only` is deprecated and accidentally broke with mono/mono#7887 This should fix device tests with `mono-2018-06`

Merge branch 'master' into mono-2018-06

b183101

Testing with Zoltan's patch

4bacab3

Include libmono-system-native on Xamarin.Mac

3b18aee

Revert 4bacab3, it doesn't fix the ios aot problems.

609f7b6

Bump mono

bda2b14

Merge branch 'master' into mono-2018-06

fdf3536

[msbuild] Fix parsing of json parser errors to handle trailing period…

fc561b2

…s in the error message. Fixes this test: 1) Test Failure : Xamarin.iOS.Tasks.Bug60536.TestACToolTaskCatchesJsonException ColumnNumber Expected: 2 But was: 0

Bump mono

db6b3b7

Merge branch 'mono-2018-06' of github.com:xamarin/xamarin-macios into…

3eeff7e

… mono-2018-06

[builds] Install the old llvm binaries into the LLVM36 directory and …

6c5544e

…make the 32 bit builds use that.

Bump mono

3901d8e

Bump to mono:2018-08

878c9d5

directhex requested a review from rolfbjarne as a code owner August 8, 2018 16:23

directhex added enable-device-build Makes our build include device support (which we disable for simple PRs to speed them up) run-all-tests Run all our tests. labels Aug 8, 2018

directhex assigned spouliot and rolfbjarne Aug 8, 2018

Merge remote-tracking branch 'origin/master' into mono-2018-08

23b7847

dalexsoto approved these changes Nov 26, 2018

View reviewed changes

Merge remote-tracking branch 'origin/master' into mono-2018-08

4e3dec7

rolfbjarne approved these changes Nov 27, 2018

View reviewed changes

mandel-macaque mentioned this pull request Nov 30, 2018

[XHarness] Add support for xunit and nunit tests on Mac OS X. #5182

Merged

spouliot merged commit 7b83195 into master Dec 6, 2018

mandel-macaque deleted the mono-2018-08 branch December 7, 2021 20:29

Uh oh!

Conversation

directhex commented Aug 8, 2018 • edited by slluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xamarin-release-manager commented Nov 20, 2018

Uh oh!

monojenkins commented Nov 20, 2018

Test results

Failed tests

Uh oh!

rolfbjarne commented Nov 21, 2018

Uh oh!

rolfbjarne commented Nov 21, 2018

Uh oh!

marek-safar commented Nov 22, 2018 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rolfbjarne commented Nov 23, 2018

Uh oh!

xamarin-release-manager commented Nov 26, 2018

Uh oh!

monojenkins commented Nov 26, 2018

Test results

Failed tests

Uh oh!

rolfbjarne commented Nov 26, 2018

Uh oh!

GouriKumari commented Nov 26, 2018

Uh oh!

xamarin-release-manager commented Nov 27, 2018

Uh oh!

marek-safar commented Nov 27, 2018

Uh oh!

spouliot commented Nov 27, 2018

Uh oh!

monojenkins commented Nov 27, 2018

Test results

Failed tests

Uh oh!

rolfbjarne commented Nov 27, 2018

Uh oh!

xamarin-release-manager commented Nov 27, 2018

Uh oh!

dalexsoto commented Nov 27, 2018

Xamarin.Mac.dll

Namespace ObjCRuntime

Type Changed: ObjCRuntime.Constants

Uh oh!

monojenkins commented Nov 28, 2018

Uh oh!

dalexsoto commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marek-safar commented Dec 5, 2018

Uh oh!

spouliot commented Dec 5, 2018

Uh oh!

luhenry commented Dec 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

directhex commented Aug 8, 2018 •

edited by slluis

Loading

marek-safar commented Nov 22, 2018 •

edited by rolfbjarne

Loading

dalexsoto commented Dec 5, 2018 •

edited

Loading