[dotnet] Use correct relative path for install_name_tool on macOS - #9804
Merged
Conversation
6 tasks
rolfbjarne
added
macOS
rolfbjarne
requested changes
Oct 7, 2020
spouliot
approved these changes
Oct 7, 2020
mandel-macaque
approved these changes
Oct 7, 2020
mandel-macaque
left a comment
mandel-macaque
left a comment
Contributor
There was a problem hiding this comment.
+1 after rolf commit is added.
Member
|
build |
rolfbjarne
approved these changes
Oct 8, 2020
Contributor
|
Build success |
Member
Author
|
I'm working on a better fix for this problem. Looks like the .NET Core system libraries now have proper identity with This PR is still probably worth it as a stopgap solution and because of the removal of hard-coded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.