Bump mono to the latest of 2018-08 - #6236
Merged
Merged
Conversation
mandel-macaque
added
run-internal-tests
spouliot
added
the
requires-approval-before-merge
Contributor
|
Build success |
spouliot
approved these changes
Jun 10, 2019
Contributor
Author
|
lets wait for the internal tests to be done |
rolfbjarne
approved these changes
Jun 11, 2019
Contributor
Author
|
@spouliot @rolfbjarne zip failures are due to files missing in the tests dlls, something that was added in the later mono test dlls. I'll ignore them in this branch. The https tests. is due to the network :/ |
Contributor
Author
|
Added the required ignores. The issue is that the required resources are not added in the test dlls. This just happens in this branch because we are not using the mono sdk for the mac tests, something that does work in other branches. I added the ignore to get cleaner test results, does not affect the customers. |
Contributor
|
Build success |
Contributor
|
Build success |
rolfbjarne
changed the title
Contributor
Author
|
Issues are known and fixed in the backport PR: #6266 |
dalexsoto
approved these changes
Jun 12, 2019
spouliot
approved these changes
Jun 12, 2019
rolfbjarne
approved these changes
Jun 12, 2019
chamons
approved these changes
Jun 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following commits:
Complete diff: mono/mono@3cb3684...3a07bd4