[d16-1] [Tests] Try different urls before failing the test. - #6266
Merged
mandel-macaque merged 2 commits intoJun 12, 2019
Conversation
We do have a test that fails when there are issues accessing the remote resource. If an error is raised, rather than setting the tests as an error, set them to inconclusive with the message of the error. Related issue: https://github.com/xamarin/maccore/issues/1725
mandel-macaque
added
the
pr-change-not-shipping
spouliot
approved these changes
Jun 11, 2019
Contributor
Author
|
Build failure Test results3 tests failed, 0 tests skipped, 75 tests passed.Failed tests
|
rolfbjarne
approved these changes
Jun 12, 2019
rolfbjarne
added
the
requires-approval-before-merge
dalexsoto
approved these changes
Jun 12, 2019
chamons
approved these changes
Jun 12, 2019
chamons
left a comment
chamons
left a comment
Contributor
There was a problem hiding this comment.
Approved for d16-1 under "tests and infrastructure".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do have a test that fails when there are issues accessing the remote
resource. If an error is raised, rather than setting the tests as an
error, set them to inconclusive with the message of the error.
Related issue: https://github.com/xamarin/maccore/issues/1725
Backport of #6237.
/cc @mandel-macaque