Macios symbolicate by jstedfast · Pull Request #74 · dotnet/macios

jstedfast · 2016-05-24T15:45:06Z

Spec: https://docs.google.com/document/d/1dvJVMhG3naxm247XbNE-2IhbF88K-N7ogfDa1xzXUBU/edit#heading=h.yi6nd7uot6wj

xamarin-release-manager · 2016-05-24T16:15:52Z

Build success

rolfbjarne · 2016-05-24T17:31:10Z

This is unconditionally enable mSYMs by default, however iirc it was decided to only enable it by default for release builds (because it's quite useless for debug builds, and still adds to build time).

jstedfast · 2016-05-24T17:51:56Z

Something has to enable it or disable it via the .csproj settings

xamarin-release-manager · 2016-05-24T19:10:55Z

Build success

xamarin-release-manager · 2016-05-24T19:40:34Z

Build success

xamarin-release-manager · 2016-05-24T20:39:55Z

Build success

rolfbjarne · 2016-05-25T16:39:59Z

Isn't it now disabled by default instead of enabled by default? Can't you use MtouchDebug to choose a default?

jstedfast · 2016-05-25T17:05:23Z

I suppose, but the IDE is what overrides the MonoSymbolArchive variable in the .csproj.

If we want it strictly tied to MtouchDebug, then it probably doesn't make sense to have the MonoSymbolArchive variable or the --msym arg, right?

rolfbjarne · 2016-05-25T17:20:26Z

So the IDEs will write a MonoSymbolArchive variable to every csproj then?

We don't want it strictly tied to MtouchDebug, we want it default to !MtouchDebug, unless otherwise specified.

jstedfast · 2016-05-25T17:49:33Z

So the IDEs will write a MonoSymbolArchive variable to every csproj then?

Correct.

We don't want it strictly tied to MtouchDebug, we want it default to !MtouchDebug, unless otherwise specified.

Okay, we can probably do that.

jstedfast · 2016-05-25T18:18:32Z

Slight problem: Xamarin.Mac does not have anything equivalent to MtouchDebug, so it would not be consistent if we use that for Xamarin.iOS.

rolfbjarne · 2016-05-26T08:00:39Z

It would be the variable which causes /debug to be passed to mmp, which seems to be $(DebugSymbols): https://github.com/xamarin/xamarin-macios/blob/master/msbuild/Xamarin.Mac.Tasks/Xamarin.Mac.Common.targets#L469

jstedfast · 2016-05-26T19:06:31Z

Well, $(DebugSymbols) is not XM specific. It's the Csc compiler tool value which means it won't really be the same behavior as iOS...

xamarin-release-manager · 2016-05-27T18:45:57Z

Build success

rolfbjarne · 2016-05-30T08:12:14Z

 		{
 			XamMacArch arch;
-			return Enum.TryParse<XamMacArch> (Architecture, true, out arch);
+			return Enum.TryParse (Architecture, true, out arch);


This doesn't look related to the msym changes?

rolfbjarne · 2016-05-30T08:14:44Z

@jstedfast Could you rebase on master? There seems to be conflicts now.

jstedfast · 2016-05-31T15:20:36Z

rebased on master

xamarin-release-manager · 2016-05-31T15:51:06Z

Build success

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@e5a46fd [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (dotnet#73) * xamarin/Touch.Unit@f8d9a21 [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (dotnet#76) * xamarin/Touch.Unit@c151a18 [TouchRunner] Print test output to the console. (dotnet#75) * xamarin/Touch.Unit@74fbc3f [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (dotnet#74) * xamarin/Touch.Unit@857c584 [TouchRunner] Only update the UI for a single test after the test has finished running. (dotnet#72) * xamarin/Touch.Unit@85f716d [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (dotnet#71) * xamarin/Touch.Unit@8bea179 [TouchRunner] Always show 'Run all'. (dotnet#70) * xamarin/Touch.Unit@2c2a55e Move every Touch.Client projects to its own folder. (dotnet#69) * xamarin/Touch.Unit@09733ed [TouchRunner] Improve name printing in NuGet mode. (dotnet#68) * xamarin/Touch.Unit@8f2d02e Ignore any 'packages' directory. (dotnet#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..e5a46fd0a05b3c3c84a0ba013463e957311db6f2

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (dotnet#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (dotnet#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (dotnet#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (dotnet#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (dotnet#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (dotnet#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (dotnet#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (dotnet#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (dotnet#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (dotnet#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (dotnet#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (dotnet#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (dotnet#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (dotnet#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (dotnet#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (dotnet#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (dotnet#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (dotnet#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (dotnet#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (dotnet#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (dotnet#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (dotnet#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (dotnet#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (dotnet#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (dotnet#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (dotnet#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (dotnet#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (dotnet#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (dotnet#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (dotnet#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (dotnet#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (dotnet#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (dotnet#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (dotnet#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (dotnet#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (dotnet#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (dotnet#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (dotnet#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (dotnet#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (dotnet#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (dotnet#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (dotnet#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (dotnet#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (dotnet#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (dotnet#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (dotnet#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (dotnet#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (dotnet#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (dotnet#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (dotnet#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (dotnet#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (dotnet#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (dotnet#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (dotnet#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (dotnet#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (dotnet#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (dotnet#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (dotnet#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (dotnet#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (dotnet#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (dotnet#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (dotnet#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c

This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c

This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (dotnet#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (dotnet#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (dotnet#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (dotnet#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (dotnet#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (dotnet#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (dotnet#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (dotnet#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (dotnet#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (dotnet#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (dotnet#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (dotnet#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (dotnet#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c

This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@f620668 [Touch.Client] Adjust project configurations. (dotnet#83) * xamarin/Touch.Unit@545400b [Touch.Client] Fix paths in the .NET project files. (dotnet#81) * xamarin/Touch.Unit@703586b [Touch.Client] Add API to exclude tests based on categories. (dotnet#82) * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (dotnet#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (dotnet#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (dotnet#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (dotnet#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (dotnet#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (dotnet#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (dotnet#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (dotnet#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (dotnet#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (dotnet#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (dotnet#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (dotnet#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (dotnet#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..f62066880ae548bac9302d714b8c045955051014

jstedfast added 2 commits May 23, 2016 13:46

[msbuild] Added support for Mono symbolication

c238a9d

[msbuild] Archive appex mSYM data as well

2ca7ee0

dnfclas added the cla-already-signed label May 24, 2016

jstedfast added 2 commits May 24, 2016 14:37

[msbuild] Default MonoSymbolArchive to false

1810912

[msbuild] Make sure the mSYM dir exists before archiving

82b44e7

[msbuild] Default MonoSymbolArchive to False for Mac as well

c4fd850

[msbuild] Only pass --msym if the value is explicitly set

c2de101

rolfbjarne reviewed May 30, 2016
View reviewed changes

Merge branch 'master' into macios-symbolicate

cf7cf9e

jstedfast merged commit 582101a into dotnet:master May 31, 2016

jstedfast deleted the macios-symbolicate branch November 28, 2016 21:20

rolfbjarne added a commit to rolfbjarne/macios that referenced this pull request Apr 5, 2019

azdevops: dotnet#74.

ee02d94

Uh oh!

Conversation

jstedfast commented May 24, 2016 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xamarin-release-manager commented May 24, 2016

Uh oh!

rolfbjarne commented May 24, 2016

Uh oh!

jstedfast commented May 24, 2016

Uh oh!

xamarin-release-manager commented May 24, 2016

Uh oh!

xamarin-release-manager commented May 24, 2016

Uh oh!

xamarin-release-manager commented May 24, 2016

Uh oh!

rolfbjarne commented May 25, 2016

Uh oh!

jstedfast commented May 25, 2016

Uh oh!

rolfbjarne commented May 25, 2016

Uh oh!

jstedfast commented May 25, 2016

Uh oh!

jstedfast commented May 25, 2016

Uh oh!

rolfbjarne commented May 26, 2016

Uh oh!

jstedfast commented May 26, 2016

Uh oh!

xamarin-release-manager commented May 27, 2016

Uh oh!

rolfbjarne May 30, 2016

Choose a reason for hiding this comment

Uh oh!

rolfbjarne commented May 30, 2016

Uh oh!

jstedfast commented May 31, 2016

Uh oh!

xamarin-release-manager commented May 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jstedfast commented May 24, 2016 •

edited by rolfbjarne

Loading