Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions msbuild/Xamarin.Mac.Tasks/Tasks/Mmp.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
using System;

namespace Xamarin.Mac.Tasks
{
public class Mmp : MmpTaskBase
Expand Down
1 change: 1 addition & 0 deletions msbuild/Xamarin.Mac.Tasks/Xamarin.Mac.Common.targets
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,7 @@ Copyright (C) 2014 Xamarin. All rights reserved.
TargetFrameworkVersion="$(TargetFrameworkVersion)"
UseXamMacFullFramework="$(UseXamMacFullFramework)"
Architecture="$(XamMacArch)"
ArchiveSymbols="$(MonoSymbolArchive)"
LinkMode="$(LinkMode)"
Debug="$(DebugSymbols)"
HttpClientHandler="$(HttpClientHandler)"
Expand Down
4 changes: 4 additions & 0 deletions msbuild/Xamarin.MacDev.Tasks.Core/Tasks/ArchiveTaskBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ protected string DSYMDir {
get { return AppBundleDir.ItemSpec + ".dSYM"; }
}

protected string MSYMDir {
get { return AppBundleDir.ItemSpec + ".mSYM"; }
}

protected string XcodeArchivesDir {
get {
var home = Environment.GetFolderPath (Environment.SpecialFolder.Personal);
Expand Down
25 changes: 21 additions & 4 deletions msbuild/Xamarin.iOS.Tasks.Core/Tasks/ArchiveTaskBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,18 @@ void ArchiveAppExtension (ITaskItem appex, string archiveDir)
}

var dsymDir = appex.ItemSpec + ".dSYM";
var destDir = Path.Combine (archiveDir, "dSYMs", Path.GetFileName (dsymDir));

Ditto (dsymDir, destDir);
if (Directory.Exists (dsymDir)) {
var destDir = Path.Combine (archiveDir, "dSYMs", Path.GetFileName (dsymDir));
Ditto (dsymDir, destDir);
}

var msymDir = appex.ItemSpec + ".mSYM";

if (Directory.Exists (msymDir)) {
var destDir = Path.Combine (archiveDir, "mSYMs", Path.GetFileName (msymDir));
Ditto (msymDir, destDir);
}
}

void AddIconPaths (PArray icons, PArray iconFiles, string productsDir)
Expand Down Expand Up @@ -136,8 +145,16 @@ public override bool Execute ()
Ditto (AppBundleDir.ItemSpec, appDestDir);

// Archive the dSYMs...
var dsymsDestDir = Path.Combine (archiveDir, "dSYMs", Path.GetFileName (DSYMDir));
Ditto (DSYMDir, dsymsDestDir);
if (Directory.Exists (DSYMDir)) {
var destDir = Path.Combine (archiveDir, "dSYMs", Path.GetFileName (DSYMDir));
Ditto (DSYMDir, destDir);
}

// Archive the mSYMs...
if (Directory.Exists (MSYMDir)) {
var destDir = Path.Combine (archiveDir, "mSYMs", Path.GetFileName (MSYMDir));
Ditto (MSYMDir, destDir);
}

// Archive the Bitcode symbol maps
var bcSymbolMaps = Directory.GetFiles (Path.GetDirectoryName (DSYMDir), "*.bcsymbolmap");
Expand Down
7 changes: 7 additions & 0 deletions msbuild/Xamarin.iOS.Tasks.Core/Tasks/MTouchTaskBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ public GccOptions ()

public string Architectures { get; set; }

public string ArchiveSymbols { get; set; }

[Required]
public string CompiledEntitlements { get; set; }

Expand Down Expand Up @@ -339,6 +341,7 @@ protected override string GenerateCommandLineCommands ()
{
var args = new ProcessArgumentBuilder ();
TargetArchitecture architectures;
bool msym;

if (string.IsNullOrEmpty (Architectures) || !Enum.TryParse (Architectures, out architectures))
architectures = TargetArchitecture.Default;
Expand Down Expand Up @@ -492,6 +495,9 @@ protected override string GenerateCommandLineCommands ()
// don't have mtouch generate the dsyms...
args.Add ("--dsym=no");

if (!string.IsNullOrEmpty (ArchiveSymbols) && bool.TryParse (ArchiveSymbols.Trim (), out msym))
args.Add ("--msym=" + (msym ? "yes" : "no"));

var gcc = new GccOptions ();

if (!string.IsNullOrEmpty (ExtraArgs)) {
Expand Down Expand Up @@ -607,6 +613,7 @@ public override bool Execute ()
Log.LogTaskProperty ("AppExtensionReferences", AppExtensionReferences);
Log.LogTaskProperty ("AppManifest", AppManifest);
Log.LogTaskProperty ("Architectures", Architectures);
Log.LogTaskProperty ("ArchiveSymbols", ArchiveSymbols);
Log.LogTaskProperty ("BitcodeEnabled", EnableBitcode);
Log.LogTaskProperty ("CompiledEntitlements", CompiledEntitlements);
Log.LogTaskProperty ("Debug", Debug);
Expand Down
1 change: 1 addition & 0 deletions msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,7 @@ Copyright (C) 2013-2016 Xamarin. All rights reserved.
UseThumb="$(MtouchUseThumb)"
EnableBitcode="$(MtouchEnableBitcode)"
AppExtensionReferences="@(_ResolvedAppExtensionReferences)"
ArchiveSymbols="$(MonoSymbolArchive)"
Verbosity="$(MtouchVerbosity)"
>
<Output TaskParameter="CompiledArchitectures" PropertyName="_CompiledArchitectures" />
Expand Down