[Runtime] Enable the -Wsign-conversion on trampolines.m files. - #7447
Merged
mandel-macaque merged 1 commit intoNov 15, 2019
Merged
Conversation
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
spouliot
reviewed
Nov 14, 2019
| @end | ||
|
|
||
| #pragma clang diagnostic pop No newline at end of file | ||
| #pragma clang diagnostic pop |
Contributor
There was a problem hiding this comment.
^ check your editor settings, it seems you change the last line endings very frequently
spouliot
approved these changes
Nov 14, 2019
Contributor
|
Build failure Test results1 tests failed, 86 tests passed.Failed tests
|
rolfbjarne
approved these changes
Nov 15, 2019
Contributor
Author
|
Known issue: https://github.com/xamarin/maccore/issues/581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the flag that was disabled via pragmas and fix warnings.
Continuation of PR: #7405