[Runtime] Enable the -Wsign-conversion warnings flag and fix some of the warnings. by mandel-macaque · Pull Request #7405 · dotnet/macios

mandel-macaque · 2019-11-11T22:58:49Z

The flag adds a lot (A LOT) of warnings. The diff would be huge and
dangerous to review. We enable the flag and fix file by file.

…he warnings. The flag adds a lot (A LOT) of warnings. The diff would be huge and dangerous to review. We enable the flag and fix file by file.

monojenkins · 2019-11-11T23:05:12Z

Build failure
❌ Build failed or was aborted

monojenkins · 2019-11-11T23:25:31Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

monojenkins · 2019-11-12T03:32:10Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

6 tests failed, 82 tests passed.

Failed tests

link all/Mac Modern/Debug: Failed (Test run failed.)
link all/Mac Modern/Release: Failed (Test run failed.)
link sdk/Mac Modern/Debug: Failed (Test run failed.)
link sdk/Mac Modern/Release: Failed (Test run failed.)
monotouch-test/tvOS - simulator/Debug: Failed
monotouch-test/watchOS 32-bits - simulator/Debug: Crashed

rolfbjarne · 2019-11-12T06:59:50Z


 #ifndef GPOINTER_TO_INT
-#define GPOINTER_TO_INT(p) ((int)  (long) (p))
+#define GPOINTER_TO_INT(p) ((uint32_t)  (long) (p))


This makes the macro name incorrect, so:

Suggested change

#define GPOINTER_TO_INT(p) ((uint32_t) (long) (p))

#define GPOINTER_TO_UINT(p) ((uint32_t) (long) (p))

make sense, but the above #ifndef needs to be updated too
i.e. don't commit suggestion alone :)

I can't it would not compile. It is a larger change (is used in several places) but can be done in this PR.

…acaque/xamarin-macios into partial-enable-Wsign-conversion

monojenkins · 2019-11-12T19:35:41Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

20 tests failed, 68 tests passed.

Failed tests

link all/Mac Modern/Debug: Failed (Test run failed.)
link all/Mac Modern/Release: Failed (Test run failed.)
link sdk/Mac Modern/Debug: Failed (Test run failed.)
link sdk/Mac Modern/Release: Failed (Test run failed.)
monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
framework-test/watchOS 32-bits - simulator/Debug: Crashed
interdependent-binding-projects/watchOS 32-bits - simulator/Debug: Crashed
fsharp/watchOS 32-bits - simulator/Debug: Crashed
introspection/watchOS 32-bits - simulator/Debug: Crashed
dont link/watchOS 32-bits - simulator/Debug: Crashed
dont link/watchOS 32-bits - simulator/Release: Crashed
link all/watchOS 32-bits - simulator/Debug: Crashed
link all/watchOS 32-bits - simulator/Release: Crashed
link sdk/watchOS 32-bits - simulator/Debug: Crashed
link sdk/watchOS 32-bits - simulator/Release: Crashed
mono-native-compat/watchOS 32-bits - simulator/Debug: Crashed
mono-native-unified/watchOS 32-bits - simulator/Debug: Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Crashed
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Crashed

mandel-macaque · 2019-11-12T20:10:02Z

HE0038 (https://github.com/xamarin/maccore/issues/581) and issues with the msdn page that are fixed by #7401

Enable the flag that was disabled via pragmas. Continuation of PR: dotnet#7405

Enable the flag that was disabled via pragmas. Continuation of PR: #7405

Enable the flag that was disabled via pragmas. Continuation of PR: dotnet#7405

…7428) Enable the flag that was disabled via pragmas. Continuation of PR: #7405

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

…#7455) Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

) Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

Update flags: * Add -Werror so that warnings are errors. * Move to -Wconversion that adds: * -Wbitfield-enum-conversion * -Wbool-conversion * -Wconstant-conversion * -Wenum-conversion * -Wfloat-conversion * -Wimplicit-float-conversion * -Wimplicit-int-conversion * -Wint-conversion * -Wliteral-conversion * -Wnon-literal-null-conversion * -Wnull-conversion * -Wobjc-literal-conversion * -Wshorten-64-to-32 * -Wsign-conversion * -Wstring-conversion Last work related to: dotnet#7405

Update flags: * Add -Werror so that warnings are errors. * Move to -Wconversion that adds: * -Wbitfield-enum-conversion * -Wbool-conversion * -Wconstant-conversion * -Wenum-conversion * -Wfloat-conversion * -Wimplicit-float-conversion * -Wimplicit-int-conversion * -Wint-conversion * -Wliteral-conversion * -Wnon-literal-null-conversion * -Wnull-conversion * -Wobjc-literal-conversion * -Wshorten-64-to-32 * -Wsign-conversion * -Wstring-conversion Last work related to: #7405

[Runtime] Enable the -Wsign-conversion watning flag and fix some of t…

2359075

…he warnings. The flag adds a lot (A LOT) of warnings. The diff would be huge and dangerous to review. We enable the flag and fix file by file.

mandel-macaque requested review from rolfbjarne and spouliot as code owners November 11, 2019 22:58

mandel-macaque changed the title ~~[Runtime] Enable the -Wsign-conversion watning flag and fix some of the warnings.~~ [Runtime] Enable the -Wsign-conversion warnings flag and fix some of the warnings. Nov 11, 2019

dalexsoto approved these changes Nov 11, 2019

View reviewed changes

Undo mistaken change.

4e46229

whitneyschmidt approved these changes Nov 11, 2019

View reviewed changes

Comment thread runtime/trampolines-varargs.m Outdated

Reduce noise.

8acfccc

rolfbjarne requested changes Nov 12, 2019

View reviewed changes

spouliot approved these changes Nov 12, 2019

View reviewed changes

mandel-macaque added 2 commits November 12, 2019 11:30

Rename macro.

25f1bb2

Merge branch 'partial-enable-Wsign-conversion' of github.com:mandel-m…

a90d685

…acaque/xamarin-macios into partial-enable-Wsign-conversion

rolfbjarne approved these changes Nov 12, 2019

View reviewed changes

mandel-macaque merged commit 63ab48e into dotnet:master Nov 12, 2019

mandel-macaque deleted the partial-enable-Wsign-conversion branch November 12, 2019 20:10

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 13, 2019

[Runtime] Enable the -Wsign-conversion on trampilines-varargs files.

99261eb

Enable the flag that was disabled via pragmas. Continuation of PR: dotnet#7405

mandel-macaque mentioned this pull request Nov 13, 2019

[Runtime] Enable the -Wsign-conversion on trampolines-varargs files. #7428

Merged

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 13, 2019

[Runtime] Enable the -Wsign-conversion on trampolines-invoke.m

9973186

Enable the flag that was disabled via pragmas. Continuation of PR: dotnet#7405

mandel-macaque mentioned this pull request Nov 13, 2019

[Runtime] Enable the -Wsign-conversion on trampolines-invoke.m #7429

Merged

mandel-macaque added a commit that referenced this pull request Nov 14, 2019

[Runtime] Enable the -Wsign-conversion on trampolines-invoke.m (#7429)

dc0a877

Enable the flag that was disabled via pragmas. Continuation of PR: #7405

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 14, 2019

[Runtime] Enable the -Wsign-conversion on trampilines-varargs files.

d50364a

Enable the flag that was disabled via pragmas. Continuation of PR: dotnet#7405

mandel-macaque added a commit that referenced this pull request Nov 14, 2019

[Runtime] Enable the -Wsign-conversion on trampolines-varargs files. (#…

5e2231d

…7428) Enable the flag that was disabled via pragmas. Continuation of PR: #7405

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 14, 2019

[Runtime] Enable the -Wsign-conversion on trampolines.m files.

2a1f60a

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 14, 2019

[Runtime] Enable the -Wsign-conversion on trampolines.m files.

70919b0

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 14, 2019

[Runtime] Enable the -Wsign-conversion on trampolines.m files.

8d7e08c

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 14, 2019

[Runtime] Enable the -Wsign-conversion on trampolines.m files.

bc7fa24

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque mentioned this pull request Nov 14, 2019

[Runtime] Enable the -Wsign-conversion on trampolines.m files. #7447

Merged

mandel-macaque added a commit that referenced this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on trampolines.m files. (#7447)

af196f1

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on trampolines-x86_64.m files.

515625c

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque mentioned this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on trampolines-x86_64.m files. #7455

Merged

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on monotouch-main.m files.

1cb9112

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque mentioned this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on monotouch-main.m files. #7457

Merged

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on monotouch-debug files.

236a71f

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque mentioned this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on monotouch-debug files. #7459

Merged

mandel-macaque added a commit that referenced this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on trampolines-x86_64.m files. (…

481d5ef

…#7455) Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 15, 2019

[Runtime] Enable the -Wsign-conversion on runtime.m files.

5265263

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque added a commit that referenced this pull request Nov 18, 2019

[Runtime] Enable the -Wsign-conversion on monotouch-main.m files. (#7457

4aa269b

) Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

mandel-macaque added a commit that referenced this pull request Nov 20, 2019

[Runtime] Enable the -Wsign-conversion on monotouch-debug files. (#7459)

8f6a10f

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Nov 20, 2019

[Runtime] Enable the -Wsign-conversion on runtime.m files.

7bc7ae6

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405

mandel-macaque mentioned this pull request Nov 20, 2019

[Runtime] Enable the -Wsign-conversion on runtime.m files. #7474

Merged

mandel-macaque added a commit that referenced this pull request Nov 21, 2019

[Runtime] Enable the -Wsign-conversion on runtime.m files. (#7474)

6a702cb

Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405

mandel-macaque mentioned this pull request Nov 21, 2019

[Runtime] Update cflags and fix warnings accordingly. #7478

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Runtime] Enable the -Wsign-conversion warnings flag and fix some of the warnings. - #7405

[Runtime] Enable the -Wsign-conversion warnings flag and fix some of the warnings.#7405
mandel-macaque merged 5 commits into
dotnet:masterfrom
mandel-macaque:partial-enable-Wsign-conversion

mandel-macaque commented Nov 11, 2019

Uh oh!

monojenkins commented Nov 11, 2019

Uh oh!

Uh oh!

monojenkins commented Nov 11, 2019

Uh oh!

monojenkins commented Nov 12, 2019

Failed tests

Uh oh!

rolfbjarne Nov 12, 2019

Uh oh!

spouliot Nov 12, 2019

Uh oh!

mandel-macaque Nov 12, 2019

Uh oh!

monojenkins commented Nov 12, 2019

Failed tests

Uh oh!

mandel-macaque commented Nov 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	#define GPOINTER_TO_INT(p) ((uint32_t) (long) (p))
	#define GPOINTER_TO_UINT(p) ((uint32_t) (long) (p))

Uh oh!

Conversation

mandel-macaque commented Nov 11, 2019

Uh oh!

monojenkins commented Nov 11, 2019

Uh oh!

Uh oh!

monojenkins commented Nov 11, 2019

Uh oh!

monojenkins commented Nov 12, 2019

Test results

Failed tests

Uh oh!

rolfbjarne Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

spouliot Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Nov 12, 2019

Test results

Failed tests

Uh oh!

mandel-macaque commented Nov 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants