Skip to content

[Harness] Move to create a more general TestTasks class to be reused. - #8286

Merged
mandel-macaque merged 4 commits into
masterfrom
refactor-base-test-task
Apr 8, 2020
Merged

[Harness] Move to create a more general TestTasks class to be reused.#8286
mandel-macaque merged 4 commits into
masterfrom
refactor-base-test-task

Conversation

@mandel-macaque

Copy link
Copy Markdown
Contributor

Some of the Jenkins test tasks are very useful and do A LOT of stuff. So
we try to generalize the base class, to later be able to share the most
usebul ones in the shared lib.

Some of the Jenkins test tasks are very useful and do A LOT of stuff. So
we try to generalize the base class, to later be able to share the most
usebul ones in the shared lib.
@mandel-macaque mandel-macaque added the run-internal-tests If tests should be executed on the internal Jenkins instance. label Apr 3, 2020
@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Failed to publish results 🔥

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

Needs #8289 to be merged.

Comment thread tests/xharness/Jenkins/TestTasks/JenkinsTestTask.cs Outdated
public bool Crashed => (ExecutionResult & TestExecutingResult.Crashed) == TestExecutingResult.Crashed;
public bool TimedOut => (ExecutionResult & TestExecutingResult.TimedOut) == TestExecutingResult.TimedOut;
public bool BuildFailure => (ExecutionResult & TestExecutingResult.BuildFailure) == TestExecutingResult.BuildFailure;
public bool HarnessException => (ExecutionResult & TestExecutingResult.HarnessException) == TestExecutingResult.HarnessException;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of code moved in this file, I have no idea if there are any actual changes or not.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes in the code at all.

Co-Authored-By: Rolf Bjarne Kvinge <rolf@xamarin.com>
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Package XM tests' 🔥 : java.io.IOException: MicrosoftAzureStorage - Error occurred while uploading to Azure - bosstoragemirror

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)

compilation errors added by the review suggestions.
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

@xamarin-release-manager

Copy link
Copy Markdown
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 184 tests passed.

Failed tests

  • mmptest/macOS/Debug: Failed (Execution failed with exit code 1)

@mandel-macaque
mandel-macaque merged commit f891076 into master Apr 8, 2020
@mandel-macaque
mandel-macaque deleted the refactor-base-test-task branch May 21, 2020 04:04
mandel-macaque added a commit that referenced this pull request Aug 5, 2020
…#8286)

Some of the Jenkins test tasks are very useful and do A LOT of stuff. So
we try to generalize the base class, to later be able to share the most
usebul ones in the shared lib.

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
mandel-macaque added a commit that referenced this pull request Oct 12, 2020
…#8286)

Some of the Jenkins test tasks are very useful and do A LOT of stuff. So
we try to generalize the base class, to later be able to share the most
usebul ones in the shared lib.

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-internal-tests If tests should be executed on the internal Jenkins instance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants