[Harness] Fix the generation of the sources. - #8289
Merged
Merged
Conversation
The name of the dll changed, ergo the prefix changed.
mandel-macaque
added
the
run-internal-tests
dalexsoto
approved these changes
Apr 5, 2020
Contributor
|
Build success |
premun
approved these changes
Apr 6, 2020
premun
reviewed
Apr 6, 2020
|
|
||
| // resource related static vars used to copy the embedded src to the hd | ||
| static string srcResourcePrefix = "Xharness.TestImporter.Templates.Managed.Resources.src."; | ||
| static string srcResourcePrefix = "Microsoft.DotNet.XHarness.iOS.Shared.TestImporter.Templates.Managed.Resources.src."; |
Member
There was a problem hiding this comment.
This could also probably be resolved through reflection
Contributor
Author
There was a problem hiding this comment.
Enhancement I want to add :)
rolfbjarne
approved these changes
Apr 6, 2020
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException ✅ Build succeeded ✅ API Diff (from stable) |
dalexsoto
pushed a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
Apr 6, 2020
The name of the dll changed, ergo the prefix changed. New commits in xamarin/maccore: * xamarin/maccore@a14f74b40a Revert "[Localization] Rework mlaunch (dotnet#2171)" (dotnet#2194) * xamarin/maccore@9939a3812d [mlaunch] Accept the latest C# language version in projects (dotnet#2193) Diff: https://github.com/xamarin/maccore/compare/fdeec0f4ccdfdb9111d594b7f7189cd58e06216d..a14f74b40ac5ed01a9a384d758b50e5a7c563569
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of the dll changed, ergo the prefix changed.