Skip to content

[Jenkins] Add nuint xml logs - #883

Merged
mandel-macaque merged 17 commits into
dotnet:masterfrom
mandel-macaque:add-nuint-xml-logs
Nov 15, 2016
Merged

[Jenkins] Add nuint xml logs#883
mandel-macaque merged 17 commits into
dotnet:masterfrom
mandel-macaque:add-nuint-xml-logs

Conversation

@mandel-macaque

Copy link
Copy Markdown
Contributor

Change the execution of the tests to output info in xml to be able to parsed by jenkins.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

Comment thread tests/xharness/AppRunner.cs Outdated
args.Append (" -argument=-app-arg:-enablenetwork");
args.Append (" -setenv=NUNIT_ENABLE_NETWORK=true");
// detect if we are using a jenkins bot.
if (!string.IsNullOrEmpty (Environment.GetEnvironmentVariable ("BUILD_REVISION"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a Harness.InWrench method, so it makes sense to extract this to a Harness.InJenkins method as well.

@mandel-macaque mandel-macaque added the do-not-merge Do not merge this pull request label Sep 23, 2016
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

Build

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

@rolfbjarne I was debugging, the test were not being executed as I wanted in jenkins so I wanted to see if the message was added. Will remove if it is just garbage.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@rolfbjarne

Copy link
Copy Markdown
Member

Yeah, the @MonkeyWrench prefix doesn't make sense. Also it only works on wrench 😄

@mandel-macaque

Copy link
Copy Markdown
Contributor Author

@rolfbjarne learning by touching ;) Lets see this next build, I have high hopes. If everything works, we should have much better comments from the bot.

@mandel-macaque
mandel-macaque force-pushed the add-nuint-xml-logs branch 2 times, most recently from 07ce061 to 59c367d Compare September 26, 2016 14:07
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@spouliot spouliot removed the do-not-merge Do not merge this pull request label Oct 26, 2016
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@rolfbjarne

Copy link
Copy Markdown
Member

The watchOS tests are still crashing.

@mandel-macaque
mandel-macaque force-pushed the add-nuint-xml-logs branch 3 times, most recently from 25d354a to 6554c38 Compare November 4, 2016 09:02
@mandel-macaque
mandel-macaque force-pushed the add-nuint-xml-logs branch 4 times, most recently from 046e2cc to 32202b4 Compare November 7, 2016 15:41
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

2 similar comments
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

Comment thread tests/xharness/AppRunner.cs Outdated
}
}

void GenerateHumanReadableLogs (string finalPath, string logHeader, XmlDocument doc){

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Opening brace goes on the next line.

Comment thread tests/xharness/AppRunner.cs Outdated
}
}

public bool TestsSucceeded (LogStream listener_log, bool timed_out, bool crashed) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Opening brace goes on the next line.

Harness.LogWrench ("@MonkeyWrench: AddSummary: <b><i>{0} timed out</i></b><br/>", mode);
success = false;
} else if (launch_failure) {
Harness.LogWrench ("@MonkeyWrench: AddSummary: <b><i>{0} failed to launch</i></b><br/>", mode);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've lost this launch_failure condition (it was added after you started your branch, and probably got removed at some when you rebased).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixing.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@monojenkins

Copy link
Copy Markdown
Contributor

Build success

Comment thread tests/xharness/AppRunner.cs Outdated
main_log.WriteLine ("Test run never launched");
success = false;
} else if (launch_failure) {
Harness.LogWrench ("@MonkeyWrench: AddSummary: <b><i>{0} failed to launch</i></b><br/>", mode);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation looks wrong here.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

2 similar comments
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@monojenkins

Copy link
Copy Markdown
Contributor

Build success

@mandel-macaque
mandel-macaque merged commit aa38ab6 into dotnet:master Nov 15, 2016
@mandel-macaque
mandel-macaque deleted the add-nuint-xml-logs branch November 15, 2016 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants