Revert "Fix binding project LinkWithAttributes generation to prevent rebuilds" - #1018
Merged
Merged
Conversation
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Oct 24, 2016
…rebuilds" (dotnet#1018) Duration before: 1,60s Duration after: 1,54s Difference: -0,06s = -3,8% The memory usage is almost identical (down 21kb of a total of ~540mb), but the number of method calls fell significantly: Method calls before: 86.720.379 Method calls after: 74.390.061 Difference: -12.330.318 = -14,2% In the method call summary the call to GetSystemVoidType is #2 before (1072 calls taking 1429ms), after the fix it's way down the list, only called once.
mandel-macaque
pushed a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Oct 25, 2016
mandel-macaque
pushed a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Oct 25, 2016
mandel-macaque
pushed a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Oct 28, 2016
mandel-macaque
pushed a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 4, 2016
mandel-macaque
pushed a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 4, 2016
mandel-macaque
pushed a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 7, 2016
mandel-macaque
pushed a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 14, 2016
mandel-macaque
pushed a commit
that referenced
this pull request
Nov 15, 2016
* [Jenkins] Make test to write output as an xml file so that it can be parsed by the jenkins bot. * Point to the correct Touvh.Unit repo. * Use the available property to determine if we are being ran in Jenkins. * Log where are test results stored. * Add @MonkeyWrench: prefix. * Ensure that we do set the build env in jenkins/run-tests.sh * Do not mix Wrench with Jenkins. The reports in jenkins can be Xml, in Wrench we prefer the old style. * Ensure that the main node of the unit tests does contain the target, that will improve the tests results reporting. * Revert "Fix binding project LinkWithAttributes generation to prevent rebuilds" (#1018) * Added xslt to be used to keep the old Test Reports until we move to only Jenkins reports. * Add an extra log for the xslt transformation. * Point to the correcto dir in jenkins. * Deal with the xslt once we have finished rather than in a batch. * Remove noise. * Readd case removed in rebase. * Fix indentation. * Skip lock keychain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1017
It depends on #1014, which hasn't been merged yet, so it doesn't build: