Skip to content

[tests] Skip the TypeDescriptorCanary test in .NET. - #9527

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:dotnet-tests-skip-typedescriptorcanary
Aug 27, 2020
Merged

[tests] Skip the TypeDescriptorCanary test in .NET.#9527
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:dotnet-tests-skip-typedescriptorcanary

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

It tests internal implementation details, and those details have now changed
(dotnet/runtime#39973). So just skip the entire test
for now.

Fixes this test failure:

DontLink.CommonDontLinkTest
    [FAIL] TypeDescriptorCanary : System.InvalidCastException : Specified cast is not valid. :    at DontLink.CommonDontLinkTest.TypeDescriptorCanary() in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/linker/CommonDontLinkTest.cs:line 22
        at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

It tests internal implementation details, and those details have now changed
(dotnet/runtime#39973). So just skip the entire test
for now.

Fixes this test failure:

    DontLink.CommonDontLinkTest
        [FAIL] TypeDescriptorCanary : System.InvalidCastException : Specified cast is not valid. :    at DontLink.CommonDontLinkTest.TypeDescriptorCanary() in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/linker/CommonDontLinkTest.cs:line 22
            at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants