Make ComponentModel intrinsic TypeConverters linker-safe - #39973
Merged
Conversation
|
Tagging subscribers to this area: @safern |
pranavkm
reviewed
Jul 27, 2020
Member
|
Can we add a couple tests for this? |
eerhardt
reviewed
Jul 27, 2020
pranavkm
reviewed
Jul 28, 2020
danmoseley
reviewed
Aug 3, 2020
…to new method, add trimming tests
eerhardt
reviewed
Aug 6, 2020
Member
Since this method is only used for editors now, can we:
Refers to: src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs:1336 in 072efce. [](commit_id = 072efce, deletion_comment = False) |
eerhardt
reviewed
Aug 6, 2020
eerhardt
reviewed
Aug 6, 2020
eerhardt
reviewed
Aug 6, 2020
eerhardt
approved these changes
Aug 6, 2020
eerhardt
left a comment
eerhardt
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thanks for getting this taken care of. This should eliminate the need for the LinkerWorkaround.xml in Blazor now.
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Make ComponentModel intrinsic TypeConverters linker-safe * Avoid reflection in converter func lookup * Re-add code path that supports editors * Consolidate intrinsic converter caches, move converter-specific code to new method, add trimming tests * Address feedback * Revert change to GetIntrinsicTypeEditor method * Handle inheritance with Uri and CultureInfo types * Add heirarchy-related comments to cache docs
4 tasks
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Aug 27, 2020
It tests internal implementation details, and those details have now changed (dotnet/runtime#39973). So just skip the entire test for now. Fixes this test failure: DontLink.CommonDontLinkTest [FAIL] TypeDescriptorCanary : System.InvalidCastException : Specified cast is not valid. : at DontLink.CommonDontLinkTest.TypeDescriptorCanary() in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/linker/CommonDontLinkTest.cs:line 22 at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
rolfbjarne
added a commit
to dotnet/macios
that referenced
this pull request
Aug 27, 2020
It tests internal implementation details, and those details have now changed (dotnet/runtime#39973). So just skip the entire test for now. Fixes this test failure: DontLink.CommonDontLinkTest [FAIL] TypeDescriptorCanary : System.InvalidCastException : Specified cast is not valid. : at DontLink.CommonDontLinkTest.TypeDescriptorCanary() in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/linker/CommonDontLinkTest.cs:line 22 at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38582