Skip to content

[tests][xtro] Check for missing/extra [Appearance]. Fix #7136 - #9765

Merged
spouliot merged 2 commits into
dotnet:mainfrom
spouliot:gh7136
Oct 2, 2020
Merged

[tests][xtro] Check for missing/extra [Appearance]. Fix #7136#9765
spouliot merged 2 commits into
dotnet:mainfrom
spouliot:gh7136

Conversation

@spouliot

@spouliot spouliot commented Oct 1, 2020

Copy link
Copy Markdown
Contributor

based on the header's UI_APPEARANCE_SELECTOR decorations

Fix #7136

Draft - existing extra must be reviewed

based on the header's `UI_APPEARANCE_SELECTOR` decorations

Fix dotnet#7136
@spouliot spouliot added the enhancement The issue or pull request is an enhancement label Oct 1, 2020
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 53 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)

@spouliot
spouliot marked this pull request as ready for review October 2, 2020 13:20
@spouliot
spouliot requested a review from dalexsoto as a code owner October 2, 2020 13:20
@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Provisioning succeeded
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@spouliot
spouliot merged commit 144f926 into dotnet:main Oct 2, 2020
@spouliot
spouliot deleted the gh7136 branch October 2, 2020 17:52
@spouliot

spouliot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

@monojenkins backport to xcode12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement The issue or pull request is an enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check for appearance properties in the xtro tests

5 participants