Skip to content

[dotnet] Avoid using install_name_tool on macOS and specify correct rpath instead - #9819

Merged
rolfbjarne merged 2 commits into
dotnet:mainfrom
filipnavara:fix-rpath
Oct 13, 2020
Merged

[dotnet] Avoid using install_name_tool on macOS and specify correct rpath instead#9819
rolfbjarne merged 2 commits into
dotnet:mainfrom
filipnavara:fix-rpath

Conversation

@filipnavara

Copy link
Copy Markdown
Member

No description provided.

@chamons

chamons commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

I'll let @rolfbjarne be primary reviewer on this.

@filipnavara - What prompted this work - There isn't an explanation in the PR itself.

@filipnavara

Copy link
Copy Markdown
Member Author

Ah, sorry. I forgot to put it in the description. It contributes to fixing issue #9800 and uses a better approach than #9804 to fix the same underlying problem. The comment in the source code around _UpdateDynamicLibraryId explains that it's a temporary hack for a build issue in dotnet/runtime. On macOS the hack is not necessary since the binaries are produced with proper identity (eg. @rpath/libXXX.dylib) in the runtime pack. It works as long as the linking step specifies correct relative paths (the bundle structure is different between iOS and macOS) which this PR fixes.

Comment thread dotnet/targets/Xamarin.Shared.Sdk.targets Outdated
@rolfbjarne

Copy link
Copy Markdown
Member

build

@rolfbjarne rolfbjarne added community Community contribution ❤ dotnet An issue or pull request related to .NET (6) macOS Issues affecting macOS run-dotnet-tests Run all the .NET tests labels Oct 8, 2020
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Oct 8, 2020
@rolfbjarne

Copy link
Copy Markdown
Member

build

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@rolfbjarne
rolfbjarne merged commit 5e79ca4 into dotnet:main Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Community contribution ❤ dotnet An issue or pull request related to .NET (6) macOS Issues affecting macOS run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants