Skip to content

Add support for running with tfm=net9.0#3428

Merged
LoopedBard3 merged 9 commits intodotnet:mainfrom
radical:net9
Oct 19, 2023
Merged

Add support for running with tfm=net9.0#3428
LoopedBard3 merged 9 commits intodotnet:mainfrom
radical:net9

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Oct 19, 2023

  • ChannelMap: add entry for 9.0
  • nuget.config: add dotnet9 source
  • Add 9.0 versions for package references

@radical radical mentioned this pull request Oct 19, 2023
Merged
@radical radical marked this pull request as ready for review October 19, 2023 04:56
@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

Don't merge yet.

@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

Related PR - dotnet/BenchmarkDotNet#2447 .

@radical radical mentioned this pull request Oct 19, 2023
Closed
@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

@LoopedBard3 @cincuranet could we get the latest BDN package published to the nuget feed?

error NU1102: Unable to find package BenchmarkDotNet.Diagnostics.Windows with version (>= 0.13.10-nightly.20231019.90)
error NU1102:   - Found 49 version(s) in benchmark-dotnet-prerelease [ Nearest version: 0.13.9-nightly.20230908.70 ]

@radical radical requested a review from lewing October 19, 2023 16:34
@LoopedBard3
Copy link
Copy Markdown
Member

LoopedBard3 commented Oct 19, 2023

@radical the 0.13.10-nightly.20231019.90 version should now be available.

LoopedBard3
LoopedBard3 previously approved these changes Oct 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread scripts/channel_map.py
lewing
lewing reviewed Oct 19, 2023
View reviewed changes
Comment thread NuGet.config
@radical @lewing
Update NuGet.config
bda2d15 
Co-authored-by: Larry Ewing <lewing@microsoft.com>
@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

Failure is relevant, investigating now.

DrewScoggins
DrewScoggins reviewed Oct 19, 2023
View reviewed changes
Comment thread scripts/channel_map.py
'main': {
'tfm': 'net8.0',
'branch': '8.0',
'tfm': 'net9.0',
Copy link
Copy Markdown
Member

@DrewScoggins DrewScoggins Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also go ahead and add all of the release/9.0* branches as well?

@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

The blazor_scenarios fails with:
[2023/10/19 18:04:43][INFO] /datadisks/disk1/work/BA02099F/p/artifacts/packages/microsoft.net.sdk.webassembly.pack/9.0.0-alpha.1.23470.17/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets(157,38): error MSB4057: The target "WasmBuildApp" does not exist in the project. [/datadisks/disk1/work/BA02099F/w/AFEA0949/e/app/BlazingPizza.Client/BlazingPizza.Client.csproj::TargetFramework=net9.0]

.. which is because the latest sdk still has a much older WorkloadManifest (note 9.0.0-alpha.1.23470.17 in the path) which is missing bunch of changes needed to support building with net9.0, thus the webassembly.sdk is not imported and we get this error.
This will have to be ignored for now, as the the flow of runtime through to installer is stuck right now. But we can validate the changes with a run on dotnet-runtime-perf.

The sdk_scenarios failures are not related, IIUC.

@radical radical closed this Oct 19, 2023
@radical radical reopened this Oct 19, 2023
@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

A new installer is available, so I triggered a rebuild.

@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

All the blazor_scenarios pass now with the new installer! Only unrelated failures are left.

@radical radical enabled auto-merge (squash) October 19, 2023 21:31
@LoopedBard3 LoopedBard3 disabled auto-merge October 19, 2023 21:49
@LoopedBard3 LoopedBard3 merged commit 5035eb2 into dotnet:main Oct 19, 2023
@radical radical deleted the net9 branch October 20, 2023 00:32
@caaavik-msft caaavik-msft mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewing lewing lewing left review comments

@DrewScoggins DrewScoggins DrewScoggins left review comments

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@cincuranet cincuranet Awaiting requested review from cincuranet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical @LoopedBard3 @lewing @DrewScoggins