Skip to content

[wasm] Fix perf pipeline runs#93688

Merged
radical merged 5 commits intodotnet:mainfrom
radical:perf-nugets-ci
Oct 20, 2023
Merged

[wasm] Fix perf pipeline runs#93688
radical merged 5 commits intodotnet:mainfrom
radical:perf-nugets-ci

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Oct 18, 2023 •
edited
Loading

  • Update to use tfm=net9.0

  • Add Microsoft.NETCore.App.Ref nuget to helix payload to fix /home/helixbot/work/AEA10974/p/performance/src/scenarios/blazor/app/emptyblazorwasmtemplate.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 9.0.0-ci)

  • Run only a few benchmarks on runtime-wasm-perf as it is just a sanity check run. And running a full partition can take more than 30mins.

Corresponding PR - dotnet/performance#3428

@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Oct 18, 2023
@radical radical self-assigned this Oct 18, 2023
@ghost
Copy link
Copy Markdown

ghost commented Oct 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes /home/helixbot/work/AEA10974/p/performance/src/scenarios/blazor/app/emptyblazorwasmtemplate.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 9.0.0-ci)

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@radical radical added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 18, 2023
@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 18, 2023

wip: aot run didn't aot for some reason!

@radical radical changed the title [wasm] perf: Copy targeting pack nuget also for perf pipeline [wasm] Fix perf pipeline runs Oct 19, 2023
@radical radical marked this pull request as ready for review October 19, 2023 04:55
@radical radical mentioned this pull request Oct 19, 2023
Closed
@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

This is blocked on dotnet/BenchmarkDotNet#2447, and dotnet/performance#3428 .

@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

wip: aot run didn't aot for some reason!

This was because wasm/net9.0 didn't have some handling in dotnet/performance, and dotnet//BenchmarkDotnet but failed silently, falling back to coreclr.

@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 19, 2023

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2295935

@radical radical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 20, 2023
@radical
Copy link
Copy Markdown
Member Author

radical commented Oct 20, 2023

Merging to fix CI.

@radical radical merged commit 50f6502 into dotnet:main Oct 20, 2023
@radical radical deleted the perf-nugets-ci branch October 20, 2023 02:39
@AndyAyersMS AndyAyersMS mentioned this pull request Oct 24, 2023
Closed
@radekdoulik radekdoulik mentioned this pull request Oct 25, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical @lewing