Migrate perf artifact download steps to DownloadPipelineArtifact@2#5262
Merged
DrewScoggins merged 1 commit intoJul 16, 2026
Merged
Conversation
DownloadBuildArtifacts@0 cannot read Pipeline Artifacts, whereas DownloadPipelineArtifact@2 downloads both Build and Pipeline Artifacts. Migrating the download side first unblocks dotnet/runtime moving its artifact publishing to Pipeline Artifacts, while remaining compatible with the current Build Artifact producers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a76ca5e8-9da2-412f-8f6f-5a61d5ba62f5
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates shared Azure DevOps pipeline templates to use DownloadPipelineArtifact@2 instead of DownloadBuildArtifacts@0, so downstream perf pipelines can successfully consume both legacy Build Artifacts and newer Pipeline Artifacts (avoiding missing-download failures that break subsequent ExtractFiles@1 steps).
Changes:
- Migrate the “current build” shared download template to
DownloadPipelineArtifact@2and settargetPathto preserve the existing__download__/<artifactName>/...layout. - Migrate the “specific build” shared download template to
DownloadPipelineArtifact@2, mappingpipeline→definitionandbuildId→pipelineId. - Remove inputs that are not applicable to the new task (
downloadType,downloadPath,checkDownloadedFiles).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/templates/download-artifact-step.yml | Switches artifact download to DownloadPipelineArtifact@2 while keeping the unzip glob working via targetPath. |
| eng/pipelines/templates/download-specific-artifact-step.yml | Switches specific-build artifact download to DownloadPipelineArtifact@2 with updated input names and preserved download folder structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DrewScoggins
added a commit
that referenced
this pull request
Jul 20, 2026
* Migrate "Download binlog files" steps to DownloadPipelineArtifact@2 The two inline binlog download steps in runtime-perf-job.yml still used DownloadBuildArtifacts@0, which was missed by #5262. dotnet/runtime now publishes these binlogs as Pipeline Artifacts (#128498), so migrate the download side to DownloadPipelineArtifact@2, matching #5262's pattern (drop downloadType/checkDownloadedFiles, downloadPath -> targetPath). Paired with the runtime change giving these binlogs stable names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6f47a24b-d0d8-4286-afcc-a1f3d96552c5 * Normalize remaining downloads to DownloadPipelineArtifact@2 Migrate the last inline "Download iOS Sample App" step in runtime-perf-job.yml off DownloadBuildArtifacts@0, completing the move to DownloadPipelineArtifact@2 for all downloads in the perf pipeline YAML (eng/common is Arcade-managed and left as-is). DownloadPipelineArtifact@2 places a named artifact's contents directly in targetPath, without the <artifactName> subfolder that DownloadBuildArtifacts@0 created. The payload-staging globs in run_performance_job.py used "**" without recursive=True, so they only matched one intermediate directory and would miss the now-flattened .binlog/.zip files (fatal for the iOS sample app zip). Make those three globs recursive; recursive=True also still matches the old nested layout, so it is safe across the transition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6f47a24b-d0d8-4286-afcc-a1f3d96552c5 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the shared artifact download templates from
DownloadBuildArtifacts@0toDownloadPipelineArtifact@2:eng/pipelines/templates/download-artifact-step.ymleng/pipelines/templates/download-specific-artifact-step.ymlWhy
DownloadBuildArtifacts@0can only read legacy Build Artifacts. When a producer publishes a Pipeline Artifact, this task fails withUnsupported artifact type: PipelineArtifactand downloads nothing, causing the downstreamExtractFiles@1(Unzip) step to fail withENOENT.DownloadPipelineArtifact@2downloads both Build and Pipeline Artifacts (see the task reference — "Download build and pipeline artifacts"). Migrating the download side first is therefore backward compatible: it keeps working with today's Build Artifact producers and unblocks producers moving to Pipeline Artifacts.Context
dotnet/runtime is migrating
eng/pipelinesfromPublishBuildArtifacts@1toPublishPipelineArtifact@1in dotnet/runtime#128498. That change makes theBrowserWasm/BrowserWasmCoreCLRartifacts (consumed here viaruntime-perf-job.yml→download-artifact-step.yml) Pipeline Artifacts, which the currentDownloadBuildArtifacts@0cannot read.Merge order: this PR should merge before dotnet/runtime#128498 so the
runtime-wasm-perfpipeline keeps working across the transition.Migration details
downloadType/downloadPath/checkDownloadedFiles(not applicable toDownloadPipelineArtifact@2).targetPath: '$(Build.SourcesDirectory)/__download__/${{ parameters.artifactName }}'so the existingExtractFiles@1glob patterns (__download__/<artifactName>/...) continue to match.pipeline→definitionandbuildId→pipelineId(theDownloadPipelineArtifact@2input names).Note
This PR description and changes were generated with the assistance of GitHub Copilot.