Test failure: Regressions\\coreclr\\0570\\Test570\\Test570.cmd

[v-haren]

failed in job: runtime-coreclr outerloop 20200415.4

Error message

Return code: 1
Raw output file: C:\dotnetbuild\work\AD6B09DB\w\A6D00946\e\Regressions\coreclr\Reports\Regressions.coreclr\0570\Test570\Test570.output.txt
Raw output:
BEGIN EXECUTION
1 file(s) copied.
" "C:\dotnetbuild\work\AD6B09DB\p\crossgen.exe" /Platform_Assemblies_Paths C:\dotnetbuild\work\AD6B09DB\p;C:\dotnetbuild\work\AD6B09DB\w\A6D00946\e\Regressions\coreclr\0570\Test570 /in C:\dotnetbuild\work\AD6B09DB\w\A6D00946\e\Regressions\coreclr\0570\Test570\Test570.org /out C:\dotnetbuild\work\AD6B09DB\w\A6D00946\e\Regressions\coreclr\0570\Test570\\Test570.dll"
Microsoft (R) CoreCLR Native Image Generator - Version 4.5.30319.0
Copyright (c) Microsoft Corporation. All rights reserved.
Native image C:\dotnetbuild\work\AD6B09DB\w\A6D00946\e\Regressions\coreclr\0570\Test570\\Test570.dll generated successfully.
"C:\dotnetbuild\work\AD6B09DB\p\corerun.exe" Test570.dll 
enUS.NumberFormat.NumberDecimalDigits=3
Error: enUS.NumberFormat.NumberDecimalDigits=3, expected 2
enUS.NumberFormat.PercentDecimalDigits=3
Error: enUS.NumberFormat.PercentDecimalDigits=3, expected 2
Expected: 100
Actual: 0
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=C:\dotnetbuild\work\AD6B09DB\p
> C:\dotnetbuild\work\AD6B09DB\w\A6D00946\e\Regressions\coreclr\0570\Test570\Test570.cmd
Expected: True
Actual: False


Stack trace
   at Regressions_coreclr._0570_Test570_Test570_._0570_Test570_Test570_cmd() in F:\workspace\_work\1\s\artifacts\tests\coreclr\Windows_NT.arm64.Checked\TestWrappers\Regressions.coreclr\Regressions.coreclr.XUnitWrapper.cs:line 2080

[danmoseley]

@safern is this from #34645 ?

Tagging subscribers to this area: @tarekgh, @safern
Notify danmosemsft if you want to be subscribed.

[safern]

Seems like it yes. I’ll take a look.

[danmoseley]

Do we still have coverage of calling all these culture info property getters (like NumberDecimalDigits)? That was getting covered by TestAllCultures_Nls but I see that is disabled when not in Nls mode. I realize in Icu mode we cannot compare to the results of GetLocaleInfoEx, but at least we should check they don't throw.

I know I could figure this out if I read all your change 😊

[safern]

We’re getting coverage by the .Nls. test project which enables NLS mode. Isn’t that enough?

[safern]

But yeah we also have coverage for these properties for ICU. For example, NumberFormatInfo:

runtime/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoNumberDecimalDigits.cs

Line 23 in 1db45ed

Assert.Equal(expected, format.NumberDecimalDigits);

[danmoseley]

Yes, apologies my grep was faulty. On Windows, do we end up running tests twice, once with ICU and once with NLS?

[danmoseley]

Anyway it seems to me this test "Test570" can be deleted.

[danmoseley]

There's quite a lot that can be deleted among these tests (some other time). Eg., test583.cs just tests that DateTime.Parse(DateTime.Now.ToString()); doesn't throw. test1534.cs is a simple test of DateTime.ParseExact that should be in the libraries tests if it isn't already.

[danmoseley]

#35045