Skip to content

Fix coreclr Test570 due to ICU on Windows feature - #35435

Merged
jkotas merged 4 commits into
dotnet:masterfrom
safern:FixTest570
Apr 25, 2020
Merged

Fix coreclr Test570 due to ICU on Windows feature#35435
jkotas merged 4 commits into
dotnet:masterfrom
safern:FixTest570

Conversation

@safern

@safern safern commented Apr 25, 2020

Copy link
Copy Markdown
Member

Fixes: #35039

@ghost

ghost commented Apr 25, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern
safern requested a review from BruceForstall April 25, 2020 01:32
@safern

safern commented Apr 25, 2020

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@safern

safern commented Apr 25, 2020

Copy link
Copy Markdown
Member Author

@GrabYourPitchforks

Copy link
Copy Markdown
Member

I reviewed the "build 18362" part of the change and confirmed that it matches the 19H1 RTM build. So there's my minor contribution. :)

@safern

safern commented Apr 25, 2020

Copy link
Copy Markdown
Member Author

I reviewed the "build 18362" part of the change

Thanks 😄

@jkotas

jkotas commented Apr 25, 2020

Copy link
Copy Markdown
Member

It would be better to fix this by moving the test to live under libraries where it belongs.

@jkotas

jkotas commented Apr 25, 2020

Copy link
Copy Markdown
Member

If we have appropriate coverage under libraries, just delete the test.

@safern

safern commented Apr 25, 2020

Copy link
Copy Markdown
Member Author

We already test this in Libraries:

yield return new object[] { CultureInfo.GetCultureInfo("en-US").NumberFormat, 2, 3 };

It seems like for PercentDecimalDigits we don't have such test case:
https://github.com/dotnet/runtime/blob/4f9ae42d861fcb4be2fcd5d3d55d5f227d30e723/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoPercentDecimalDigits.cs

I guess I can just delete this test and add a test case in NumberFormatInfoPercentDecimalDigits tests

@safern

safern commented Apr 25, 2020

Copy link
Copy Markdown
Member Author

Updated to remove the test and add the missing test data in libraries test.

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas

jkotas commented Apr 25, 2020

Copy link
Copy Markdown
Member

The test failures are issues #35452 #35438 #35451

@jkotas
jkotas merged commit 1db71ea into dotnet:master Apr 25, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: Regressions\\coreclr\\0570\\Test570\\Test570.cmd

5 participants