Cross-Compilation from Arm64 to x64 fails on M1 Mac

[ivdiazsa]

Description

I was running some inter-architecture experiments with multiple OS's, when I bumped across this bug. I can't get an OSX x64 build using my M1 Mac anymore because the cross-building fails now.

Running the following command:

./build.sh --subset clr --configuration Release --cross --arch x64

Yields the following error:

[  9%] Preprocessing /path/to/runtime/src/coreclr/dlls/mscorrc/include.rc. Outputting to /path/to/runtime/artifacts/obj/coreclr/OSX.x64.Release/dlls/mscorrc/mscorrc.rc.i
  In file included from /path/to/runtime/src/coreclr/dlls/mscorrc/include.rc:4:
  In file included from /path/to/runtime/src/coreclr/dlls/mscorrc/mscorrc.rc:7:
  In file included from /path/to/runtime/src/coreclr/pal/prebuilt/inc/corerror.h:7:
  In file included from /path/to/runtime/src/coreclr/pal/inc/rt/winerror.h:12:
  In file included from /path/to/runtime/src/coreclr/pal/inc/rt/palrt.h:136:
  /path/to/runtime/src/coreclr/pal/inc/pal.h:2659:2: error: PAL_CS_NATIVE_DATA_SIZE is not defined for this architecture
  #error  PAL_CS_NATIVE_DATA_SIZE is not defined for this architecture
   ^
  [  9%] Building C object /path/to/runtime/artifacts/obj/external/libunwind/CMakeFiles/libunwind_dac.dir/path/to/runtime/src/native/external/libunwind/src/remote/mac/missing-functions.c.o
  [  9%] Building CXX object md/ceefilegen/CMakeFiles/ceefgen_obj.dir/ceegentokenmapper.cpp.o
  1 error generated.
  make[2]: *** [dlls/mscorrc/mscorrc.rc.i] Error 1
  make[1]: *** [dlls/mscorrc/CMakeFiles/mscorrc_obj.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....

It worked fine until recently, so this is a very recent failure.

Reproduction Steps

1. Clone the runtime repo to your machine
2. Issue the build command from the repo's root: ./build.sh --subset clr --cross --arch x64

Expected behavior

Build should complete successfully without any issues.

Actual behavior

Build fails at about 9%.

Regression?

Yes. Don't know exactly when it broke, but for example, it works on the Preview 7 codebase.

Known Workarounds

No workaround.

Configuration

No response

Other information

No response

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

I was running some inter-architecture experiments with multiple OS's, when I bumped across this bug. I can't get an OSX x64 build using my M1 Mac anymore because the cross-building fails now.

Running the following command:

./build.sh --subset clr --configuration Release --cross --arch x64

Yields the following error:

[  9%] Preprocessing /Users/ivdiazsa186/Development/runtime/src/coreclr/dlls/mscorrc/include.rc. Outputting to /Users/ivdiazsa186/Development/runtime/artifacts/obj/coreclr/OSX.x64.Release/dlls/mscorrc/mscorrc.rc.i
  In file included from /Users/ivdiazsa186/Development/runtime/src/coreclr/dlls/mscorrc/include.rc:4:
  In file included from /Users/ivdiazsa186/Development/runtime/src/coreclr/dlls/mscorrc/mscorrc.rc:7:
  In file included from /Users/ivdiazsa186/Development/runtime/src/coreclr/pal/prebuilt/inc/corerror.h:7:
  In file included from /Users/ivdiazsa186/Development/runtime/src/coreclr/pal/inc/rt/winerror.h:12:
  In file included from /Users/ivdiazsa186/Development/runtime/src/coreclr/pal/inc/rt/palrt.h:136:
  /Users/ivdiazsa186/Development/runtime/src/coreclr/pal/inc/pal.h:2659:2: error: PAL_CS_NATIVE_DATA_SIZE is not defined for this architecture
  #error  PAL_CS_NATIVE_DATA_SIZE is not defined for this architecture
   ^
  [  9%] Building C object /Users/ivdiazsa186/Development/runtime/artifacts/obj/external/libunwind/CMakeFiles/libunwind_dac.dir/Users/ivdiazsa186/Development/runtime/src/native/external/libunwind/src/remote/mac/missing-functions.c.o
  [  9%] Building CXX object md/ceefilegen/CMakeFiles/ceefgen_obj.dir/ceegentokenmapper.cpp.o
  1 error generated.
  make[2]: *** [dlls/mscorrc/mscorrc.rc.i] Error 1
  make[1]: *** [dlls/mscorrc/CMakeFiles/mscorrc_obj.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....

It worked fine until recently, so this is a very recent failure.

Reproduction Steps

1. Clone the runtime repo to your machine
2. Issue the build command from the repo's root: ./build.sh --subset clr --cross --arch x64

Expected behavior

Build should complete successfully without any issues.

Actual behavior

Build fails at about 9%.

Regression?

Yes. Don't know exactly when it broke, but for example, it works on the Preview 7 codebase.

Known Workarounds

No workaround.

Configuration

No response

Other information

No response

Author:	ivdiazsa
Assignees:	-
Labels:	os-mac-os-x, area-Infrastructure-coreclr
Milestone:	-

[janvorli]

@am11, git bisect shows that this got broken by your change #73530. Could you please take a look?

[janvorli]

Btw, even before the problematic change, there is another issue. The coreclr build completes ok, but the cross components build fails here:

runtime/eng/native/configureplatform.cmake

Line 449 in 04ca89d

message(FATAL_ERROR "Invalid platform and target arch combination TARGET_ARCH=${CLR_CMAKE_TARGET_ARCH} HOST_ARCH=${CLR_CMAKE_HOST_ARCH}")

The problem here is that the check is missing the arm64 host / amd64 target check as valid combination.
And even with that fixed, we hit a problem while compiling src/coreclr/pal/src/exception/seh-unwind.cpp.
There are many errors like the following:

  /Users/janvorli/git/runtime/src/coreclr/pal/src/exception/seh-unwind.cpp:263:25: error: use of undeclared identifier 'UNW_AARCH64_X29'; did you mean 'UNW_ARM64_X29'?
      unw_set_reg(cursor, UNW_AARCH64_X29, winContext->Fp);
                          ^~~~~~~~~~~~~~~
                          UNW_ARM64_X29

[janvorli]

I'll fix the other problems once the current issue with PAL_CS_NATIVE_DATA_SIZE is fixed.

[am11]

that this got broken by your change #73530.

@janvorli, I admit it has gotten worse, but did you continue bisecting to find out when was this happening:

It worked fine until recently, so this is a very recent failure.

with ./build.sh --subset clr --configuration Release --cross --arch x64? The check if host & target os/arch combination are valid is super old and I think it never would have succeeded the cross components part.

[am11]

it works on the Preview 7 codebase.

that also fails on my M1:

$ git pull --tags --all
$ git checkout v7.0.0-preview.7.22375.6
$ ./build.sh --subset clr --configuration Release --cross --arch x64
...
  -- Detecting CXX compile features - done
  CMake Error at /runtime/eng/native/configureplatform.cmake:440 (message):
    Invalid platform and target arch combination TARGET_ARCH=x64
    HOST_ARCH=arm64

@ivdiazsa, can you give us the reference where this was working? I don't think it is a regression at all.

[janvorli]

These are the other issues I've mentioned in my comment above. I've found they are caused by that check in the configureplatform.cmake and just two places in code where we use HOST_ARM64 instead of TARGET_ARM64 at one place and vice versa at the other.
I believe this cross build used to work when I have enabled build on macos arm64 initially, but I might be mistaken.

[am11]

@janvorli, could you apply this patch with rest your changes:

-#elif defined(__APPLE__) && defined(__x86_64__)
+#elif defined(__APPLE__) && defined(HOST_AMD64)

[janvorli]

Thanks a lot @am11, that did the trick. With our changes combined, the build now works. I'll create a PR for the whole fix.

[ivdiazsa]

Thanks a lot for the help @janvorli!